Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples/func_defs_add_param.py: add missing align parameter #441

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented Oct 12, 2021

class TypeDecl(Node):
__slots__ = ('declname', 'quals', 'align', 'type', 'coord', '__weakref__')
def __init__(self, declname, quals, align, type, coord=None):

I’m not sure if None is appropriate, though.

Copy link
Owner

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

For consistency I think it'd be better for this to be []

@e-kwsm
Copy link
Contributor Author

e-kwsm commented Oct 15, 2021

For consistency I think it'd be better for this to be []

Fixed.

@eliben eliben merged commit 05dc0cf into eliben:master Oct 15, 2021
@e-kwsm e-kwsm deleted the examples branch October 16, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants