New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an encoding parameter to parse_file #486

Merged

eliben merged 1 commit into eliben:master from statinf-software:feature/encoding_param

Jan 7, 2023

Contributor

jordr commented Jan 5, 2023

We may need to process files written on/output by compilers on a system with a different locale.getencoding(), which is the default of open().

This patch exposes the encoding optional parameter of open to the parse_file API.

eliben requested changes

View reviewed changes

Owner

eliben left a comment

Thanks. Please rebase on master to ensure tests are passing


          Add encoding param to parse_file

cd8bae4

jordr force-pushed the feature/encoding_param branch from f03e2d5 to cd8bae4 Compare

January 7, 2023 20:09

eliben approved these changes

View reviewed changes

eliben merged commit 5382e31 into eliben:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment