Skip to content

Commit

Permalink
fix: check for update should update the GUI
Browse files Browse the repository at this point in the history
  • Loading branch information
elibroftw committed Apr 19, 2024
1 parent e41e769 commit 6da01ed
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 9 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
Music Caster by Elijah Lopez Changelog

5.19.2
- [Fix] Update from GUI

5.19.1
- [Fix] Windows-specific issues

Expand Down
8 changes: 4 additions & 4 deletions build_files/mc_version_info.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
# For more details about fixed file info 'ffi' see: http://msdn.microsoft.com/en-us/library/ms646997.aspx
VSVersionInfo(
ffi=FixedFileInfo(
prodvers=(5, 19, 1, 0),
filevers=(5, 19, 1, 0),
prodvers=(5, 19, 2, 0),
filevers=(5, 19, 2, 0),
# Contains a bitmask that specifies the valid bits 'flags'r
mask=0x17,
# Contains a bitmask that specifies the Boolean attributes of the file.
Expand All @@ -27,12 +27,12 @@ VSVersionInfo(
'000004b0',
[StringStruct('CompanyName', 'Elijah Lopez'),
StringStruct('FileDescription', 'Music Caster'),
StringStruct('FileVersion', '5.19.1.0'),
StringStruct('FileVersion', '5.19.2.0'),
StringStruct('InternalName', 'Music Caster'),
StringStruct('LegalCopyright', 'Copyright (c) 2019 - 2024, Elijah Lopez'),
StringStruct('OriginalFilename', 'Music Caster.exe'),
StringStruct('ProductName', 'Music Caster'),
StringStruct('ProductVersion', '5.19.1.0')])
StringStruct('ProductVersion', '5.19.2.0')])
]),
VarFileInfo([VarStruct('Translation', [0, 1200])])
]
Expand Down
2 changes: 1 addition & 1 deletion build_files/setup_script.iss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#define MyAppName "Music Caster"
#define MyAppVersion "5.19.1"
#define MyAppVersion "5.19.2"
#define MyAppPublisher "Elijah Lopez"
#define MyAppURL "https://elijahlopez.ca/software#music-caster"
#define MyAppExeName "Music Caster.exe"
Expand Down
2 changes: 1 addition & 1 deletion src/meta.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VERSION = latest_version = '5.19.1'
VERSION = latest_version = '5.19.2'
UPDATE_MESSAGE = """
[NEW] Better Error Capturing
[MSG] Language translators wanted
Expand Down
6 changes: 3 additions & 3 deletions src/music_caster.py
Original file line number Diff line number Diff line change
Expand Up @@ -2430,6 +2430,9 @@ def check_for_updates(self):
if release:
# avoid showing a notification for the same latest version
self.latest_version = release['version']
State.update_available = True
if not gui_window.was_closed():
gui_window['install_update'].update(visible=True)
if settings['notifications']:
tray_notify('update_available', context=self.latest_version)

Expand Down Expand Up @@ -3707,9 +3710,6 @@ def auto_update():
if IS_FROZEN:
if platform.system() in {'Linux', 'Darwin'}:
tray_notify('update_available', context=latest_ver)
State.update_available = True
if not gui_window.was_closed():
gui_window['install_update'].update(visible=True)
elif os.path.exists(UNINSTALLER):
installer_path = get_installer_path()
# only show message on startup to not confuse the user
Expand Down

0 comments on commit 6da01ed

Please sign in to comment.