Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: JS Bundle Task #5

Merged
merged 14 commits into from
Jul 4, 2022
Merged

Feature: JS Bundle Task #5

merged 14 commits into from
Jul 4, 2022

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Jul 4, 2022

This changeset moves the JS bundle task for Elide SSR into the plugin, behind an elide {} extension. The extension is configurable in terms of tooling, target, and build mode.

Integrated with elide-dev/elide#22.

Changelog

  • Implement esbuild config-gen and build
  • Implement configuration of plugin via extension, etc
  • Add support for pre-compiling SSR bundle via Prepack
  • Update protos to account for embedded/generic assets
  • Plugin version bump -> 1.0.0-alpha2
  • Avoid requiring npm(...) deps and node {} block in downstream projects
  • Embed JS runtime package, inflate to root project, inject into build state
  • Build proto-spec for embedded JS
  • Update copy tasks to place proto-spec in application
  • Lint fixes, etc
  • Sync to monorepo

This changeset moves the JS bundle task for Elide SSR into the
plugin, behind an `elide {}` extension. The extension is
configurable in terms of tooling, target, and build mode.

Integrated with elide-dev/elide#22.

Changes enclosed:
- Implement `esbuild` config-gen and build
- Implement configuration of plugin via extension, etc
- Add support for pre-compiling SSR bundle via Prepack
- Update protos to account for embedded/generic assets
- Plugin version bump -> `1.0.0-alpha2`

Pending changes:
- Avoid requiring `npm(...)` deps and `node {}` block in
  downstream projects
@sgammon sgammon added the enhancement New feature or request label Jul 4, 2022
@sgammon sgammon self-assigned this Jul 4, 2022
@sgammon sgammon mentioned this pull request Jul 4, 2022
15 tasks
@sgammon sgammon marked this pull request as ready for review July 4, 2022 01:22
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sgammon sgammon merged commit 8a68d7c into main Jul 4, 2022
@sgammon sgammon added plugin:js JS tasks and related work feature Large PRs or issues with full-blown features feature:ssr Bugs and PRs related to SSR features and removed enhancement New feature or request labels Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:ssr Bugs and PRs related to SSR features feature Large PRs or issues with full-blown features plugin:js JS tasks and related work
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant