edit for node version 10 differences

elidoran · Jul 15, 2018 · 0df82bc · 0df82bc
1 parent e65e8a5
commit 0df82bc
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 6 deletions.
diff --git a/test/lib/js/test-arguments-slice.js b/test/lib/js/test-arguments-slice.js
@@ -19,7 +19,7 @@ describe('test arguments slicing', function() {
       3
     ],
     // context: no context
-    answer: (8 <= node && node <= 9)
+    answer: (8 <= node)
   });
   verify({ // 8-9 optimizes
     name: 'optimize slicing arguments with [].slice',
@@ -35,7 +35,7 @@ describe('test arguments slicing', function() {
       3
     ],
     // context: no context
-    answer: (8 <= node && node <= 9)
+    answer: (8 <= node)
   });
   verify({ // 8-9 optimizes
     name: 'optimize slicing arguments with [].slice and a start index',
@@ -51,7 +51,7 @@ describe('test arguments slicing', function() {
       3
     ],
     // context: no context
-    answer: (8 <= node && node <= 9)
+    answer: (8 <= node)
   });
   verify({ // 8-9 optimizes
     name: 'optimize slicing arguments with [].slice with start/end indexes',
@@ -67,7 +67,7 @@ describe('test arguments slicing', function() {
       3
     ],
     // context: no context
-    answer: (8 <= node && node <= 9)
+    answer: (8 <= node)
   });
   verify({ // 4-9 optimizes
     name: 'optimize using Array.apply to create arguments as an array',

diff --git a/test/lib/js/test-param-reassignment-sloppy.js b/test/lib/js/test-param-reassignment-sloppy.js
@@ -36,7 +36,27 @@ describe('test param reassignment SLOPPY', function() {
     },
     // args: no arg
     // context: no context
-    answer: node >= 8
+    answer: (function () {
+      // node 8/9 optimize it
+      if (node === 8 || node === 9) return true
+
+      // node 10 doesn't optimize it as of 10.6.0
+      else if (node === 10) return {
+        // spescific to node 10
+        interpreted: true,
+        mask: 65,
+        // the usuals
+        function: true,
+        maybe: false,
+        optimized: false,
+        always: false,
+        TurboFan: false
+      }
+
+      // defaults to false
+      else return false
+    })()
+
   });
   verify({
     name: 'optimize with an arguments.length based param reassignment (empty array args)',
@@ -50,7 +70,26 @@ describe('test param reassignment SLOPPY', function() {
     },
     args: [],
     // context: no context
-    answer: node >= 8
+    answer: (function () {
+      // node 8/9 optimize it
+      if (node === 8 || node === 9) return true
+
+      // node 10 doesn't optimize it as of 10.6.0
+      else if (node === 10) return {
+        // spescific to node 10
+        interpreted: true,
+        mask: 65,
+        // the usuals
+        function: true,
+        maybe: false,
+        optimized: false,
+        always: false,
+        TurboFan: false
+      }
+
+      // defaults to false
+      else return false
+    })()
   });
   verify({
     name: 'optimize with an arguments.length based param reassignment (one args)',