Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is QueryOffset::Before worth it? #36

Closed
elidupree opened this issue Aug 30, 2017 · 1 comment
Closed

Is QueryOffset::Before worth it? #36

elidupree opened this issue Aug 30, 2017 · 1 comment

Comments

@elidupree
Copy link
Owner

I wanted to include this for auditing, so that the auditing code can query immediately before and after an event. Then I exposed it to the Accessor query interface because it was easy to do so. But is it good?

  • It adds significant boilerplate to every query, and I've never actually used the Before variant in the few examples I've made so far..
  • A DataTimeline that wanted to provide Before queries would be able to implement that as separate query type of its own, in the same way that you could make a DataTimeline that answers queries about X seconds in the past.
  • It creates weirdness if you create a DataTimeline in an event and then query it using Before in the same event. (This is related to the question of whether DataTimelineCells should need a creation time.)
@elidupree
Copy link
Owner Author

It occurs to me that auditing code can ALSO implement it by simply decrementing the ExtendedTime id. (This doesn't work if the user created an event with id 0, but it makes sense for that to be forbidden anyway.) So there is no remaining need to retain this inconvenient feature.

elidupree added a commit that referenced this issue Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant