fallback to initials if the image is not loaded (#40)

[danielbprice]

Also, fix the version of vue-test-utils to 1.0.0-beta.20 to protect from breaking changes

[saintplay]

Hi, interesting solution, did you take this pattern from somewhere?

[danielbprice]

Yes, the technique is based on information I found here: https://stackoverflow.com/questions/5057990/how-can-i-check-if-a-background-image-is-loaded

[danielbprice]

I think another possibility would be to use something like https://github.com/desandro/imagesloaded ; based on my very quick read of its code (and I am not an expert) it does something somewhat similar-- creating a new Image() and then attaching events to that, although it is has more features and is battle tested across multiple browsers. It might be overkill for this application. I definitely didn't know how you would feel about adding a dependency.

[andreasvirkus]

@saintplay would you consider merging this?

[saintplay]

I didn't have time to try this. @andreasvirkus can you confirm if this works?

[danielbprice]

(I'm still here and happy to adjust this PR if there is review feedback)

[andreasvirkus]

@saintplay Checked it out and it seems to work great and not break any behaviour. You can see that the luke-skywalker.png is not found but the initials are still displayed.

@danielbprice i've added a minor comment and a question to your PR, but otherwise really eager to see this merged 🎉

(also linking to #69)

[danielbprice]

I've removed the extraneous edit to package.json (I don't know why, but I can no longer reproduce the problem with vue-test that led me to do this; perhaps I hit a window where something was broken upstream which is now fixed) and fixed the issue with the documentation noted by @andreasvirkus

Wasn't really sure if I was supposed to update the bundle, so let me know and I can strip out that change if not.

[andreasvirkus]

LGTM @saintplay

[saintplay]

@danielbprice it seems like you need to remove vue-avatar.min.js file or update your branch with git rebase

[saintplay]

Sorry I'm late, I didn't get a notification.

Released in v2.3.0

[danielbprice]

(Belatedly) Thank you! I appreciate it.