Change test_data_path and unicode conf #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 159
💛 - Coveralls |
| @@ -34,6 +34,6 @@ def read_fixture(filename, folder_name=''): | |||
| with open(full_filename, 'rb') as file_fp: | |||
| return file_fp.read() | |||
|
|
|||
| def test_data_path(file_name): | |||
| def data_path(file_name): | |||
There was a problem hiding this comment.
I think test_ prefixes are auto-detected as being test functions
giorgiosironi
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planning to initialise a new code repo, I thought I would switch to using
pytest, so I tried to run the tests on this library.After some amount of troubleshooting, I found it was picking up on the
test_data_path()function thinking it was some sort of test fixture, which it is not. That function is renamed here.pytestalso displayed warnings about bytecode values being explicitly converted to unicode in the configparser usage, and I set those values to unicode strings to avoid the warnings.Not a critical PR, but it means this library will be
pytestcompatible if merged.