Add doi property to ExternalVersionSummary type [elifesciences/enhanc…

…ed-preprints-issues#1139]
elifesciences · Jul 9, 2024 · abe62e5 · abe62e5
1 parent 8d4eb68
commit abe62e5
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 1 deletion.
diff --git a/src/types/enhanced-article.ts b/src/types/enhanced-article.ts
@@ -94,13 +94,14 @@ export type PreprintVersionSummary = {
 };
 
 export type ExternalVersionSummary = {
+  doi: string,
   versionIdentifier: string,
   published: Date | null,
   url: string,
   corrections?: {
     date: Date,
     url: string,
-  }[]
+  }[],
 };
 
 export type VersionSummary = PreprintVersionSummary | ExternalVersionSummary;

diff --git a/src/utils/generators/generate-timeline.test.ts b/src/utils/generators/generate-timeline.test.ts
@@ -46,6 +46,7 @@ const version2: EnhancedArticle = {
 };
 
 const version3Summary: VersionSummary = {
+  doi: 'doi-123v3',
   versionIdentifier: '3',
   published: new Date('2023-02-09'),
   url: 'https://doi.org/doi-123v3',

diff --git a/src/utils/generators/generate-version-history.test.ts b/src/utils/generators/generate-version-history.test.ts
@@ -46,12 +46,14 @@ const version2: EnhancedArticle = {
 };
 
 const version3Summary: VersionSummary = {
+  doi: 'doi-123v3',
   versionIdentifier: '3',
   published: new Date('2023-02-09'),
   url: 'https://doi.org/doi-123v3',
 };
 
 const version3SummaryWithCorrections: VersionSummary = {
+  doi: 'doi-123v3',
   versionIdentifier: '3',
   published: new Date('2023-02-09'),
   url: 'https://doi.org/doi-123v3',

diff --git a/src/utils/mocks/enhanced-article-with-versions.ts b/src/utils/mocks/enhanced-article-with-versions.ts
@@ -55,6 +55,7 @@ export const mock85111: EnhancedArticleWithVersions = {
       versionIdentifier: '2',
     },
     '85111v3': {
+      doi: '10.7554/eLife.85111.3',
       versionIdentifier: '3',
       published: new Date('2023-06-07T00:00:00.000Z'),
       url: 'https://elifesciences.org/articles/85111v1',

diff --git a/src/utils/type-guards.test.ts b/src/utils/type-guards.test.ts
@@ -1,6 +1,7 @@
 import { isExternalVersionSummary, isPreprintVersionSummary } from './type-guards';
 
 const externalVersionSummary = {
+  doi: '10.7554/eLife.85111.3',
   versionIdentifier: '3',
   published: new Date('2023-06-07T00:00:00.000Z'),
   url: 'https://elifesciences.org/articles/85111v1',

diff --git a/wiremock/files/preprints/85111v1.json b/wiremock/files/preprints/85111v1.json
@@ -9360,6 +9360,7 @@
       "volume": "12"
     },
     "85111v3": {
+      "doi": "10.7554/eLife.85111.3",
       "versionIdentifier": "3",
       "published": "2023-06-07T00:00:00.000Z",
       "url": "https://elifesciences.org/articles/85111v1",

diff --git a/wiremock/files/preprints/85111v2.json b/wiremock/files/preprints/85111v2.json
@@ -10100,6 +10100,7 @@
       "volume": "12"
     },
     "85111v3": {
+      "doi": "10.7554/eLife.85111.3",
       "versionIdentifier": "3",
       "published": "2023-06-07T00:00:00.000Z",
       "url": "https://elifesciences.org/articles/85111v1",