Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update figure label and max heading level #1613

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat: update figure label and max heading level #1613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6dced7e
feat: update figure label and max heading level
nlisgo Jan 23, 2024
c6cda8d
Merge branch 'master' into figure-label-a11y
nlisgo Feb 12, 2024
10be91e
feat: add misMatchThreshold setting in backstop.json
nlisgo Feb 12, 2024
c68eef2
Merge remote-tracking branch 'origin/master' into figure-label-a11y
scottaubrey May 30, 2024
e9cf1e7
Merge branch 'master' into figure-label-a11y
scottaubrey Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/atoms/figure/figure.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const Figure = ({
return (
<div className="figure-container">
<figure className="figure" {...(id && { id })}>
{label && <label className="figure__label">{label}</label>}
{label && <h4 className="figure__label">{label}</h4>}
{content}
{caption && <figcaption ref={captionRef} className={`figure__caption${expanded ? ' figure__caption--expanded' : ''}`}>{caption}</figcaption>}
</figure>
Expand Down
2 changes: 1 addition & 1 deletion src/utils/content-to-jsx.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export const contentToJsx = (content?: Content, options?: Options, index?: numbe
case 'Date':
return <time key={index}>{ contentToJsx(content.content, options)}</time>;
case 'Figure':
return <Figure key={index} id={content.id} caption={contentToJsx(content.caption, { ...options, maxHeadingLevel: 4 })} label={content.label} content={contentToJsx(content.content, options)} />;
return <Figure key={index} id={content.id} caption={contentToJsx(content.caption, { ...options, maxHeadingLevel: 5 })} label={content.label} content={contentToJsx(content.content, options)} />;
case 'ImageObject':
if (!content.contentUrl) {
return '';
Expand Down
Loading