-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move siteName selection to pageProps #2026
Move siteName selection to pageProps #2026
Conversation
Preview environment created!The preview environment has been deployed to the cluster. Client URL: https://pr-2026--epp.elifesciences.org Note: If this is a new environment, it can take a few minutes for DNS to update. |
Preview environment images deployed!The preview environment has been updated: Client URL: https://pr-2026--epp.elifesciences.org Note: Updated images can take a few minutes to roll out. |
@elifesciences/epp-tech-team @nlisgo Is this ready to go now? The test looks OK to me, and it seems to pass. |
This reverts commit fb59b0a.
…rverside-render-data
This fixes the immediate issue with biophysics colab by making sure we're retrieving config.siteName during the routing.
It does also demonstrates a possibility for routing-based layout selection, by id or some other data (e.g. from server?).