ELPP-2452 Added cache headers to recommendations #57
Conversation
|
Hi @thewilkybarkid we don't currently have a web test foundation set up for recommendations, would you like me to set that up for this? If so is there more test cases that you think should be covered? |
|
@stephenwf we will also have to add |
src/App/Kernel.php
Outdated
| } | ||
|
|
||
| public function cache(Request $request, Response $response) | ||
| { | ||
| $response->setMaxAge($this->app['config']['ttl']); |
There was a problem hiding this comment.
is there a way to override this for particular responses? (will be needed in the future)
There was a problem hiding this comment.
/ping has been added that does not use caching, make sure to merge develop in this branch to solve possible conflicts
stephenwf
force-pushed
the
feature/ELPP-2452
branch
from
3aeef43
to
ccbd73c
Compare
src/App/Kernel.php
Outdated
| @@ -430,7 +430,7 @@ public function handleException(Throwable $e): Response | |||
| return new JsonResponse(array_filter([ | |||
| 'error' => $e->getMessage(), | |||
| 'trace' => $this->app['config']['debug'] ? $e->getTraceAsString() : null, | |||
| ]), $e->getCode()); | |||
| ]), $e->getCode() ? $e->getCode() : 500); | |||
There was a problem hiding this comment.
$e->getCode() ?? Response::HTTP_INTERNAL_SERVER_ERROR?
|
We'll need a test for |
|
Now that web test cases seem well supported, I agree; there is a smoke test but it doesn't check caching headers. |
tests/src/Web/CacheHeadersTest.php
Outdated
| $this->jsonRequest('GET', '/ping'); | ||
| $response = $this->getResponse(); | ||
| $this->assertEquals(200, $response->getStatusCode()); | ||
| $this->assertEquals('max-age=300, must-revalidate, no-cache, no-store, public, stale-if-error=86400, stale-while-revalidate=300', $response->headers->get('Cache-Control')); |
There was a problem hiding this comment.
This needs to be the same as https://github.com/elifesciences/search/blob/develop/tests/src/Search/Web/PingTest.php#L25-L27
There was a problem hiding this comment.
Okay I've added in a PrivateResponse class that bypasses the cache method completely.
No description provided.