-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What's up with the 2.0.1 release? #526
Comments
Think it was a case of forgetting to update changelog as the changes are indeed also just fixes so a 2.0.1 bump seems appropriate. Can see changes here. Looking at the specific changes there seems to be a lot of formatting changes obfuscating the actual changes but given that no issues have been created since release I'm just gonna give the release the benefit of a doubt and upgrade. |
Yes, please make a proper release :) |
Just to confirm this release now works in our app which also uses pdfmake.
|
Could recent changes cause the following error? I read into this a bit, and it seems it could be a bug with npm, trying to confirm a file that hasn't completed saving to filesystem. But I was curious if anyone else has run into this one. 0 info it worked if it ends with ok |
I don't see any issue here. Please consider to close this |
This is still an issue because the changelog has still not been updated - what has changed since 2.0.0? |
Or if changelog is not used, please delete it (as we can’t rely on it anyway) |
Why is this issue closed? There is no 2.0.1 version on github and nothing in the changelog. Synchronize github and npm and then close the issue! |
We might already be on the same page but be clear, what is on github is what's been published to npm. It's just that the changelog on github has not been updated for version |
We've seen a number of malicious npm packages publishing updates on npm because the npm credentials were compromised. This is why I think it's important to have the github show that 2.0.1 is released, and what are the changes. There are several users on this issue asking for a simple update. I don't see why it would take months nor why it would be closed. I understand this project is (probably) maintained by volunteers, and everyone here is fine with some delays. Just don't close the issue @jimmywarting before tagging a commit and updating the changelog. Cheers :) |
@jimmywarting
As stated, there is no 2.0.1 release in Github: https://github.com/eligrey/FileSaver.js/releases |
Hi,
there's no mention in changelog what the new release is about? npm shows that 2.0.1 has been released. Was this an accident or did you just forgot to update changelog?
Thanks for the good work though!
The text was updated successfully, but these errors were encountered: