Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to download APK belonging to Custom Project [8-16h] #605

Closed
1 of 5 tasks
jo-elimu opened this issue Nov 21, 2017 · 3 comments
Closed
1 of 5 tasks
Assignees

Comments

@jo-elimu
Copy link
Member

jo-elimu commented Nov 21, 2017

@jo-elimu jo-elimu created this issue from a note in Custom project (In progress) Nov 21, 2017
@jo-elimu jo-elimu self-assigned this Nov 21, 2017
jo-elimu added a commit that referenced this issue Nov 21, 2017
…d-APK-belonging-to-Custom-Project

#605 Lookup APK based on the Project of A License
jo-elimu added a commit that referenced this issue Nov 21, 2017
…eName] [SELECT a FROM Application a WHERE a.packageName = :packageName AND a.project = :project]"
@jo-elimu jo-elimu moved this from In progress to Under review/testing in Custom project Nov 21, 2017
@jo-elimu jo-elimu moved this from Under review/testing to In progress in Custom project Nov 22, 2017
@jo-elimu
Copy link
Member Author

Does not work when same packageName in more than one AppCollection within the same project:

org.springframework.dao.IncorrectResultSizeDataAccessException: result returns more than one elements; nested exception is javax.persistence.NonUniqueResultException: result returns more than one elements
	at org.springframework.orm.jpa.EntityManagerFactoryUtils.convertJpaAccessExceptionIfPossible(EntityManagerFactoryUtils.java:395)
	at org.springframework.orm.jpa.vendor.HibernateJpaDialect.translateExceptionIfPossible(HibernateJpaDialect.java:227)
	at org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.translateExceptionIfPossible(AbstractEntityManagerFactoryBean.java:436)
	at org.springframework.dao.support.ChainedPersistenceExceptionTranslator.translateExceptionIfPossible(ChainedPersistenceExceptionTranslator.java:59)
	at org.springframework.dao.support.DataAccessUtils.translateIfNecessary(DataAccessUtils.java:213)
	at org.springframework.dao.support.PersistenceExceptionTranslationInterceptor.invoke(PersistenceExceptionTranslationInterceptor.java:147)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
	at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:99)
	at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:281)
	at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:96)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:208)
	at com.sun.proxy.$Proxy138.readByPackageName(Unknown Source)
	at ai.elimu.web.ApkController.handleRequest(ApkController.java:83)

@jo-elimu
Copy link
Member Author

Error reported by @tuancoltech:

[ERROR] 2017-11-25 13:35:54,166 [ai.elimu.web.servlet.CustomSimpleMappingExceptionResolver] - Handler execution resulted in exception: java.lang.NullPointerException
java.lang.NullPointerException
        at ai.elimu.dao.jpa.ApplicationVersionDaoJpa.read(ApplicationVersionDaoJpa.java:25)

for URL http://elimu.ai/apk/com.alphabetking.story.level_a-300.apk?deviceId=d814b1e6a8403bf8&checksum=943f041e75c93838e62e380e5de6a811&locale=EN&deviceModel=SM-G610F&osVersion=24&applicationId=129&appVersionCode=2000008&licenseEmail=&licenseNumber=

See https://elimu-ai.slack.com/archives/C0LDBLX3J/p1511617013000011 for more details

@jo-elimu jo-elimu moved this from Under review/testing to In progress in Custom project Nov 26, 2017
@jo-elimu jo-elimu changed the title Make it possible to download APK belonging to Custom Project [2-4h] Make it possible to download APK belonging to Custom Project [8-16h] Nov 26, 2017
@jo-elimu
Copy link
Member Author

Turns out that the java.lang.NullPointerException was due to the Android app requesting a URL containing + without first URL encoding it. Will be fixed as part of elimu-ai/appstore#133

@jo-elimu jo-elimu moved this from In progress to Ready to be implemented in Custom project Jan 20, 2018
Custom project automation moved this from Ready to be implemented to Done Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants