-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1636 upgrade to jetty 100x #1640
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1640 +/- ##
============================================
- Coverage 13.78% 13.73% -0.05%
+ Complexity 454 453 -1
============================================
Files 257 257
Lines 8503 8503
Branches 881 881
============================================
- Hits 1172 1168 -4
- Misses 7279 7284 +5
+ Partials 52 51 -1 ☔ View full report in Codecov by Sentry. |
Not sure why CI fails only on Windows build, comparing to Linux or macOS are success |
@vrudas I pressed "Re-run all jobs," and now all the unit tests succeeded: https://github.com/elimu-ai/webapp/actions/runs/7297926036?pr=1640 So it must have been a temporary problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @vrudas 🙂
The page at https://eclipse.dev/jetty/download.php says that version 10 of Jetty uses Servlet 4.0 and JSP 2.3. I think we are already at Servlet version 4.0, but only JSP version 2.2:
<dependency>
<groupId>javax.servlet.jsp</groupId>
<artifactId>jsp-api</artifactId>
<version>2.2</version>
<scope>provided</scope>
</dependency>
Can we upgrade JSP from version 2.2 to 2.3 also?
I noticed that there is a version 2.3.x available, but under a different artifactId
("javax.servlet.jsp-api" instead of "jsp-api"): https://repo.maven.apache.org/maven2/javax/servlet/jsp/javax.servlet.jsp-api/
@jo-elimu thanks for notice, will try to update JSP dependency also, and notify you after completion |
No description provided.