Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1636 upgrade to jetty 100x #1640

Merged
merged 5 commits into from
Feb 2, 2024

Conversation

vrudas
Copy link
Contributor

@vrudas vrudas commented Dec 14, 2023

No description provided.

@vrudas vrudas requested a review from a team as a code owner December 14, 2023 19:22
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6eecdb) 13.78% compared to head (8ad40ed) 13.73%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1640      +/-   ##
============================================
- Coverage     13.78%   13.73%   -0.05%     
+ Complexity      454      453       -1     
============================================
  Files           257      257              
  Lines          8503     8503              
  Branches        881      881              
============================================
- Hits           1172     1168       -4     
- Misses         7279     7284       +5     
+ Partials         52       51       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrudas
Copy link
Contributor Author

vrudas commented Dec 14, 2023

Not sure why CI fails only on Windows build, comparing to Linux or macOS are success

@jo-elimu
Copy link
Member

Not sure why CI fails only on Windows build, comparing to Linux or macOS are success

@vrudas I pressed "Re-run all jobs," and now all the unit tests succeeded: https://github.com/elimu-ai/webapp/actions/runs/7297926036?pr=1640

So it must have been a temporary problem.

jo-elimu
jo-elimu previously approved these changes Dec 22, 2023
Copy link
Member

@jo-elimu jo-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vrudas 🙂

The page at https://eclipse.dev/jetty/download.php says that version 10 of Jetty uses Servlet 4.0 and JSP 2.3. I think we are already at Servlet version 4.0, but only JSP version 2.2:

        <dependency>
            <groupId>javax.servlet.jsp</groupId>
            <artifactId>jsp-api</artifactId>
            <version>2.2</version>
            <scope>provided</scope>
        </dependency>

Can we upgrade JSP from version 2.2 to 2.3 also?

I noticed that there is a version 2.3.x available, but under a different artifactId ("javax.servlet.jsp-api" instead of "jsp-api"): https://repo.maven.apache.org/maven2/javax/servlet/jsp/javax.servlet.jsp-api/

@vrudas
Copy link
Contributor Author

vrudas commented Dec 22, 2023

@jo-elimu thanks for notice, will try to update JSP dependency also, and notify you after completion

@nya-elimu nya-elimu merged commit e761c37 into elimu-ai:main Feb 2, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants