Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with stylelint 15.10.0 #12

Closed
silverwind opened this issue Jul 4, 2023 · 5 comments
Closed

Incompatible with stylelint 15.10.0 #12

silverwind opened this issue Jul 4, 2023 · 5 comments

Comments

@silverwind
Copy link

stylelint/stylelint#6999 has removed a file imported by this module. I think it's better for the future that this plugin only relies on clearly public API in stylelint and not do file-level imports.

Error: Cannot find module 'stylelint/lib/utils/isRangeContextMediaFeature'
Require stack:
- node_modules/stylelint-stylistic/dist/rules/media-feature-name-case/index.js
- node_modules/stylelint-stylistic/dist/main.js
- node_modules/stylelint/lib/augmentConfig.js
- node_modules/stylelint/lib/createStylelint.js
- node_modules/stylelint/lib/resolveConfig.js
- node_modules/stylelint/lib/printConfig.js
- node_modules/stylelint/lib/cli.js
- node_modules/stylelint/bin/stylelint.js
@Mouvedia
Copy link

Mouvedia commented Jul 4, 2023 •
edited
Loading

related:

@Mouvedia Mouvedia mentioned this issue Jul 4, 2023
Closed
@ybiquitous
Copy link

@silverwind Thanks for following up on the new Stylelint version!

At this point, I suggest the following:

  • Use the stylelint.utils.* API as possible. That API is public, and the Stylelint team ensures compatibility.
  • Copy utility files used to this repository. They're used internally, the Stylelint team doesn't ensure compatibility.
    • Of course, we may publish some of them from now on, but I cannot ensure it now.

@ybiquitous ybiquitous mentioned this issue Jul 5, 2023
Merged
@elirasza
Copy link
Owner

elirasza commented Jul 5, 2023

I originally wanted to avoid code duplicates, but your point is right. All utilities not found in the API will be moved in this project, others will be directed to the API. Thank you for your warning !

@tagliala tagliala mentioned this issue Jul 5, 2023
Closed
@dbatiste dbatiste mentioned this issue Jul 5, 2023
Merged
@karl-sjogren karl-sjogren mentioned this issue Jul 7, 2023
Closed
@karl-sjogren
Copy link
Contributor

I would love to see this getting a quick fix so that I can close my dependabot PRs that want to upgrade stylelint so I've made a small PR that fixes the immediate problem in #13.

@TyIsI TyIsI mentioned this issue Jul 7, 2023
Closed
@silverwind silverwind mentioned this issue Jul 8, 2023
Merged
silverwind added a commit to go-gitea/gitea that referenced this issue Jul 8, 2023
@silverwind
Update JS dependencies, misc tweaks (#25768)
429c12f 
- Update all JS dependencies minus stylelint because of
elirasza/stylelint-stylistic#12
- Misc tweaks to eslint and stylelint configs
- Tested Monaco and Mermaid
tagliala added a commit to diowa/ruby3-rails7-bootstrap-heroku that referenced this issue Jul 9, 2023
@tagliala
Fix stylelint dependency
fe9c87e 
Ref: elirasza/stylelint-stylistic#12
@elirasza
Copy link
Owner

elirasza commented Jul 9, 2023

Thanks to karl-sjogren in #13, this has been fixed in 0.4.3 :)

@elirasza elirasza closed this as completed Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@silverwind @Mouvedia @ybiquitous @karl-sjogren @elirasza