Re-Add (Local) support for nerd fonts #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested via local proxy- It seems to work perfectly fine behind the proxy, though I can't comment on the performance / whether different sessions need to backhaul these assets for each session between the sharing session to the proxy or not. |
|
Latest pushes change the font source to a CDN for (ideally) reduced load on the server, and no extra load on the proxy as a result of delivering these font assets. There's a small loading time for the real fontset to arrive locally, wherein it falls back to courier-new, then system monospace. For now, this isn't ready to merge until I can squash all inclusions of the font assets since they're large, and deprecated, & shouldn't make it into the main repo index. |
|
I've migrated the font assets to a CDN with an external stylesheet that references them corectly. |
elisescu
requested changes
Dec 20, 2020
There was a problem hiding this comment.
I had a few inline comments - there are some leftovers that can be removed, as they don't seem to be needed with this new CDN change.
I like the CDN change better than including the fonts in the binary.
I didn't forget about your original change in tty-server :) , and wanted to include it in this version 2 but it became very complex to mess with the paths of resources given how they are routed by the proxy. Also the binary became too big and I decided to leave them out - I want to keep the binary as small as possible.
But great idea with having them on a CDN, and a fallback font to use if/when CDN is down.
Trust me- I know Though the CDN is overall probably going to be better (less load on proxies & less overhead bandwidth from session hosts), the main motivation for the switch was to avoid stuffing with the routing paths. |
strazto
added a commit
to strazto/tty-share
that referenced
this pull request
Jan 7, 2021
…ering of glyphs (elisescu/tty-server#16) Taken from elisescu/tty-server#16 This was applied to the now defunct tty-server project, but the changes were never moved accross to the hosting functionality given by this project. Changes made to new patch (these changes were commited & squashed): * Update webpack font publicPath to relative * Update paths to source files within patch * Move fonts to CDN, and reference font stylesheet via external `<style> tag` * Remove actual font files from project (they're heavyweight) * Remove introduced frontend dependencies from package.json & package-lock.json, as per review [comment](elisescu#26 (comment)) & [comment](elisescu#26 (comment)) Changes made in original PR: Patch taken from this commit, paths updated & conflicts fixed * Squashed commit of the following ( Squash performed for tty-server#16 ): (Done for a cleaner merge) commit 3f2ef96c66a23a6afe043ccc54a4911373eec730 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:23:23 2020 +0000 Completely remove devDependencies commit 5b7b34c86c8faec9cc99c2f6f548f650b43878f5 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:22:05 2020 +0000 Change install deps from dev to production commit 2b23f00d7d621df32b9c00a776d3bf176aba2d31 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:08:30 2020 +0000 Oops add more detail to Sauce Code Pro provenance commit 56696b2bcbc9594bee0bb39f155b7024456b8ea0 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:07:54 2020 +0000 Acknowledge SauceCodePro provenence/license commit bfb93f49826843f2c4f0e2a8325cc660b272f41c Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:00:53 2020 +0000 Revert "Regen assets_bundle.go" This reverts commit 51f189421b26078367c8354de6ee0a43e3def32b. This is because I don't want this diff in the squash just yet commit ac15b25af6270ff22a43281639f3870b572c243b Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:57:49 2020 +0000 Resolve unnecessary diffs commit 8a274365dcfb83952ab211e6fd185701ad0b8649 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:50:07 2020 +0000 Add some fallback fonts if SauceCodePro is loading commit 8ff2901bc79a0d3eec452f5a945ec5d3bb6a0cab Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:30:36 2020 +0000 Remove SO comment ( wasnt relevant ) commit aa29bf232e3faf3c277df2ad5b62d33405d79604 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:29:47 2020 +0000 Finally fix font pathing commit 86a5ec20cdf8f98b57854849a29d047387e64a4f Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 10:38:48 2020 +0000 Use publicPath ? commit d225edb5f9c8e5e8ddbbe7d2de38ba0703b61995 Merge: 492a835 81295b8 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 10:28:19 2020 +0000 Merge branch 'fonts' of https://github.com/mstr3336/tty-server into fonts commit 492a83589d672c3922a8bdf94813af7df096a5ea Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 10:26:59 2020 +0000 Comment stack overflow link in webpack config commit 81295b8689f218f695a6e214cb4f2d7d1f31b269 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 20:26:22 2020 +1000 Move stuff to static i guess? commit a3a2238d3548f95dc9ddcf71d18f90f8f16f0c74 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:49:58 2020 +1000 Specify esmodule false for font loader commit be7cc94ade9bd7e8d247148ac8f09111899c677e Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:39:03 2020 +1000 Hopefully make webpack load fonts? commit 97e76cee0be5d29fa796a7fb239410b1d915dd98 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:31:28 2020 +1000 Add file-loader npm module commit 913ce076fb41146f37a98296fbdb8cee5b14d044 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:25:40 2020 +1000 Change font setting in tty-reciever.ts to new font commit 2387c0132b5fb4f61d7a7b3f3fa70d0b6f07c2b4 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:24:44 2020 +1000 Add nerd font rules commit 622d834bf9f0025ea3c03380e904a1a7c9ec5147 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:23:43 2020 +1000 Fix format spec for fonts commit 6df46eacf7da99ad2eba2c56ad8d36209bdd616c Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:20:50 2020 +1000 Finish script for building stylesheet commit e47d0de28b7becc2f16d6ba4814fd1307282710f Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:15:58 2020 +1000 Add python script for building css commit b38526cca7eda401ff49a42f2646bde4fe64c841 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 18:35:54 2020 +1000 Remove _Nerd_Font suffix commit cfd461ad7e331b1a25894c1513197c422b338422 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 18:34:40 2020 +1000 Remove _Complete_Mono_Windows_Compatible suffix from new fonts commit 2333f1bf61e0a2672e87f2b5687bf179f41832b2 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 18:28:48 2020 +1000 Add sauce code pro fonts from nerdfonts commit 778f2194c975a7fdd99dda4ab33eba8864420933 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 22:20:32 2020 +1000 Remove unnessary css rule commit c86e17f9ed55cf0901a81133c30d8c65a5a4fc52 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:11:44 2020 +0000 Remove vagrantfile for clean feature branch commit 51f189421b26078367c8354de6ee0a43e3def32b Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:07:03 2020 +0000 Regen assets_bundle.go commit 3e0462604b49af18df1f52c0129ea177db74302e Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:06:39 2020 +0000 Set the fontFamily of the tty-reciever to SourceCodePro commit cd06e4b0135ce73a4469ed4f7c06e7494bf5a0b7 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:04:18 2020 +0000 Rename font family string for source code pro commit 87a50edcafb35ef5363d0048bf48e14d4ba91266 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 20:46:07 2020 +1000 Update css to include source code pro for font family commit a036043573330da5d8792416543570c0204e3f38 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 19:59:51 2020 +1000 Finally fixed env escapes commit ed7dc41c466ad803ca00358531c67d0848fce7f5 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 19:24:27 2020 +1000 Fix heredoc commit a9ad5583162430e98e6b821871b64e2fd3ec4bf5 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 18:56:25 2020 +1000 Add serve script to vagrantfile commit 433353c70f964ea1749cfb316e7ffe191a432fc3 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 18:33:11 2020 +1000 added vagrantfile * Regen server/frontend/package-lock.json after merging upstream into feature
…ering of glyphs (elisescu/tty-server#16) Taken from elisescu/tty-server#16 This was applied to the now defunct tty-server project, but the changes were never moved accross to the hosting functionality given by this project. Changes made to new patch (these changes were commited & squashed): * Update webpack font publicPath to relative * Update paths to source files within patch * Move fonts to CDN, and reference font stylesheet via external `<style> tag` * Remove actual font files from project (they're heavyweight) * Remove introduced frontend dependencies from package.json, package-lock.json, & webpack.config.js as per review [comment](elisescu#26 (comment)) & [comment](elisescu#26 (comment)). * These were required to bundle/serve the font assets, and are now redundant as these assets are fetched externally. Changes made in original PR: Patch taken from this commit, paths updated & conflicts fixed * Squashed commit of the following ( Squash performed for tty-server#16 ): (Done for a cleaner merge) commit 3f2ef96c66a23a6afe043ccc54a4911373eec730 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:23:23 2020 +0000 Completely remove devDependencies commit 5b7b34c86c8faec9cc99c2f6f548f650b43878f5 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:22:05 2020 +0000 Change install deps from dev to production commit 2b23f00d7d621df32b9c00a776d3bf176aba2d31 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:08:30 2020 +0000 Oops add more detail to Sauce Code Pro provenance commit 56696b2bcbc9594bee0bb39f155b7024456b8ea0 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:07:54 2020 +0000 Acknowledge SauceCodePro provenence/license commit bfb93f49826843f2c4f0e2a8325cc660b272f41c Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:00:53 2020 +0000 Revert "Regen assets_bundle.go" This reverts commit 51f189421b26078367c8354de6ee0a43e3def32b. This is because I don't want this diff in the squash just yet commit ac15b25af6270ff22a43281639f3870b572c243b Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:57:49 2020 +0000 Resolve unnecessary diffs commit 8a274365dcfb83952ab211e6fd185701ad0b8649 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:50:07 2020 +0000 Add some fallback fonts if SauceCodePro is loading commit 8ff2901bc79a0d3eec452f5a945ec5d3bb6a0cab Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:30:36 2020 +0000 Remove SO comment ( wasnt relevant ) commit aa29bf232e3faf3c277df2ad5b62d33405d79604 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:29:47 2020 +0000 Finally fix font pathing commit 86a5ec20cdf8f98b57854849a29d047387e64a4f Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 10:38:48 2020 +0000 Use publicPath ? commit d225edb5f9c8e5e8ddbbe7d2de38ba0703b61995 Merge: 492a835 81295b8 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 10:28:19 2020 +0000 Merge branch 'fonts' of https://github.com/mstr3336/tty-server into fonts commit 492a83589d672c3922a8bdf94813af7df096a5ea Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 10:26:59 2020 +0000 Comment stack overflow link in webpack config commit 81295b8689f218f695a6e214cb4f2d7d1f31b269 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 20:26:22 2020 +1000 Move stuff to static i guess? commit a3a2238d3548f95dc9ddcf71d18f90f8f16f0c74 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:49:58 2020 +1000 Specify esmodule false for font loader commit be7cc94ade9bd7e8d247148ac8f09111899c677e Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:39:03 2020 +1000 Hopefully make webpack load fonts? commit 97e76cee0be5d29fa796a7fb239410b1d915dd98 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:31:28 2020 +1000 Add file-loader npm module commit 913ce076fb41146f37a98296fbdb8cee5b14d044 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:25:40 2020 +1000 Change font setting in tty-reciever.ts to new font commit 2387c0132b5fb4f61d7a7b3f3fa70d0b6f07c2b4 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:24:44 2020 +1000 Add nerd font rules commit 622d834bf9f0025ea3c03380e904a1a7c9ec5147 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:23:43 2020 +1000 Fix format spec for fonts commit 6df46eacf7da99ad2eba2c56ad8d36209bdd616c Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:20:50 2020 +1000 Finish script for building stylesheet commit e47d0de28b7becc2f16d6ba4814fd1307282710f Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:15:58 2020 +1000 Add python script for building css commit b38526cca7eda401ff49a42f2646bde4fe64c841 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 18:35:54 2020 +1000 Remove _Nerd_Font suffix commit cfd461ad7e331b1a25894c1513197c422b338422 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 18:34:40 2020 +1000 Remove _Complete_Mono_Windows_Compatible suffix from new fonts commit 2333f1bf61e0a2672e87f2b5687bf179f41832b2 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 18:28:48 2020 +1000 Add sauce code pro fonts from nerdfonts commit 778f2194c975a7fdd99dda4ab33eba8864420933 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 22:20:32 2020 +1000 Remove unnessary css rule commit c86e17f9ed55cf0901a81133c30d8c65a5a4fc52 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:11:44 2020 +0000 Remove vagrantfile for clean feature branch commit 51f189421b26078367c8354de6ee0a43e3def32b Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:07:03 2020 +0000 Regen assets_bundle.go commit 3e0462604b49af18df1f52c0129ea177db74302e Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:06:39 2020 +0000 Set the fontFamily of the tty-reciever to SourceCodePro commit cd06e4b0135ce73a4469ed4f7c06e7494bf5a0b7 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:04:18 2020 +0000 Rename font family string for source code pro commit 87a50edcafb35ef5363d0048bf48e14d4ba91266 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 20:46:07 2020 +1000 Update css to include source code pro for font family commit a036043573330da5d8792416543570c0204e3f38 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 19:59:51 2020 +1000 Finally fixed env escapes commit ed7dc41c466ad803ca00358531c67d0848fce7f5 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 19:24:27 2020 +1000 Fix heredoc commit a9ad5583162430e98e6b821871b64e2fd3ec4bf5 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 18:56:25 2020 +1000 Add serve script to vagrantfile commit 433353c70f964ea1749cfb316e7ffe191a432fc3 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 18:33:11 2020 +1000 added vagrantfile * Regen server/frontend/package-lock.json after merging upstream into feature
This is a squash of a few commits- The most important being that the assets_bundle.go was regenerated with, then without the bundled fonts in this squash, so this commit doesn't contain extraneous assets. Messages: * Regen assets_bundle * Regen assets_bundle (without fonts)
|
@elisescu , thank you for the observations, you're absolutely right, the dependencies added to |
elisescu
pushed a commit
that referenced
this pull request
Jan 7, 2021
…ering of glyphs (elisescu/tty-server#16) Taken from elisescu/tty-server#16 This was applied to the now defunct tty-server project, but the changes were never moved accross to the hosting functionality given by this project. Changes made to new patch (these changes were commited & squashed): * Update webpack font publicPath to relative * Update paths to source files within patch * Move fonts to CDN, and reference font stylesheet via external `<style> tag` * Remove actual font files from project (they're heavyweight) * Remove introduced frontend dependencies from package.json, package-lock.json, & webpack.config.js as per review [comment](#26 (comment)) & [comment](#26 (comment)). * These were required to bundle/serve the font assets, and are now redundant as these assets are fetched externally. Changes made in original PR: Patch taken from this commit, paths updated & conflicts fixed * Squashed commit of the following ( Squash performed for tty-server#16 ): (Done for a cleaner merge) commit 3f2ef96c66a23a6afe043ccc54a4911373eec730 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:23:23 2020 +0000 Completely remove devDependencies commit 5b7b34c86c8faec9cc99c2f6f548f650b43878f5 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:22:05 2020 +0000 Change install deps from dev to production commit 2b23f00d7d621df32b9c00a776d3bf176aba2d31 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:08:30 2020 +0000 Oops add more detail to Sauce Code Pro provenance commit 56696b2bcbc9594bee0bb39f155b7024456b8ea0 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:07:54 2020 +0000 Acknowledge SauceCodePro provenence/license commit bfb93f49826843f2c4f0e2a8325cc660b272f41c Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 05:00:53 2020 +0000 Revert "Regen assets_bundle.go" This reverts commit 51f189421b26078367c8354de6ee0a43e3def32b. This is because I don't want this diff in the squash just yet commit ac15b25af6270ff22a43281639f3870b572c243b Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:57:49 2020 +0000 Resolve unnecessary diffs commit 8a274365dcfb83952ab211e6fd185701ad0b8649 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:50:07 2020 +0000 Add some fallback fonts if SauceCodePro is loading commit 8ff2901bc79a0d3eec452f5a945ec5d3bb6a0cab Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:30:36 2020 +0000 Remove SO comment ( wasnt relevant ) commit aa29bf232e3faf3c277df2ad5b62d33405d79604 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Fri Sep 25 04:29:47 2020 +0000 Finally fix font pathing commit 86a5ec20cdf8f98b57854849a29d047387e64a4f Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 10:38:48 2020 +0000 Use publicPath ? commit d225edb5f9c8e5e8ddbbe7d2de38ba0703b61995 Merge: 492a835 81295b8 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 10:28:19 2020 +0000 Merge branch 'fonts' of https://github.com/mstr3336/tty-server into fonts commit 492a83589d672c3922a8bdf94813af7df096a5ea Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 10:26:59 2020 +0000 Comment stack overflow link in webpack config commit 81295b8689f218f695a6e214cb4f2d7d1f31b269 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 20:26:22 2020 +1000 Move stuff to static i guess? commit a3a2238d3548f95dc9ddcf71d18f90f8f16f0c74 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:49:58 2020 +1000 Specify esmodule false for font loader commit be7cc94ade9bd7e8d247148ac8f09111899c677e Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:39:03 2020 +1000 Hopefully make webpack load fonts? commit 97e76cee0be5d29fa796a7fb239410b1d915dd98 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:31:28 2020 +1000 Add file-loader npm module commit 913ce076fb41146f37a98296fbdb8cee5b14d044 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:25:40 2020 +1000 Change font setting in tty-reciever.ts to new font commit 2387c0132b5fb4f61d7a7b3f3fa70d0b6f07c2b4 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:24:44 2020 +1000 Add nerd font rules commit 622d834bf9f0025ea3c03380e904a1a7c9ec5147 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:23:43 2020 +1000 Fix format spec for fonts commit 6df46eacf7da99ad2eba2c56ad8d36209bdd616c Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:20:50 2020 +1000 Finish script for building stylesheet commit e47d0de28b7becc2f16d6ba4814fd1307282710f Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 19:15:58 2020 +1000 Add python script for building css commit b38526cca7eda401ff49a42f2646bde4fe64c841 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 18:35:54 2020 +1000 Remove _Nerd_Font suffix commit cfd461ad7e331b1a25894c1513197c422b338422 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 18:34:40 2020 +1000 Remove _Complete_Mono_Windows_Compatible suffix from new fonts commit 2333f1bf61e0a2672e87f2b5687bf179f41832b2 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 24 18:28:48 2020 +1000 Add sauce code pro fonts from nerdfonts commit 778f2194c975a7fdd99dda4ab33eba8864420933 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 22:20:32 2020 +1000 Remove unnessary css rule commit c86e17f9ed55cf0901a81133c30d8c65a5a4fc52 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:11:44 2020 +0000 Remove vagrantfile for clean feature branch commit 51f189421b26078367c8354de6ee0a43e3def32b Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:07:03 2020 +0000 Regen assets_bundle.go commit 3e0462604b49af18df1f52c0129ea177db74302e Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:06:39 2020 +0000 Set the fontFamily of the tty-reciever to SourceCodePro commit cd06e4b0135ce73a4469ed4f7c06e7494bf5a0b7 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 12:04:18 2020 +0000 Rename font family string for source code pro commit 87a50edcafb35ef5363d0048bf48e14d4ba91266 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 20:46:07 2020 +1000 Update css to include source code pro for font family commit a036043573330da5d8792416543570c0204e3f38 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 19:59:51 2020 +1000 Finally fixed env escapes commit ed7dc41c466ad803ca00358531c67d0848fce7f5 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 19:24:27 2020 +1000 Fix heredoc commit a9ad5583162430e98e6b821871b64e2fd3ec4bf5 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 18:56:25 2020 +1000 Add serve script to vagrantfile commit 433353c70f964ea1749cfb316e7ffe191a432fc3 Author: Matthew Strasiotto <mstr3336@uni.sydney.edu.au> Date: Thu Sep 17 18:33:11 2020 +1000 added vagrantfile * Regen server/frontend/package-lock.json after merging upstream into feature
|
Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15 .
The changes made here are (mostly) copied across from elisescu/tty-server#16 , with slight modifications to fit new path / routing structures.
As yet - only tested on local session due to #24 , and I'm not sure about the cachability of the new (heavy) assets.
I'll run a local proxy & see if I need to replicate the static asset structure between the two.
For now, they appear at
localhost:8000/s/local/static/fonts/. I imagine that in public sessions they will appear aturl/s/[sessionid]/static/fonts/.Ideally these would sit behind some cloudflare/cloudfront cdn type service, as they're not lightweight dependencies.