Read GOOGLE_CREDENTIALS during startup, not app compilation #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request escapes the reference to the GOOGLE_CREDENTIALS environment variable when creating the
$BUILD_DIR/.profile.d/google-credentials.sh
script, so the script ends up containing:This variable is then read during startup when the profile.d script runs and its current contents written to
/app/google-credentials.json
. (Prior to this change it was being read during compilation, and not with the suggested approach of going via $ENV_DIR).Tested against
heroku-18
stack.