Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnforcePodAnnotations #13

Merged
merged 32 commits into from
Aug 3, 2019
Merged

EnforcePodAnnotations #13

merged 32 commits into from
Aug 3, 2019

Conversation

elithrar
Copy link
Owner

@elithrar elithrar commented Jul 23, 2019 •
edited
Loading

Fixes #9 -

TODO:

  • Consider whether this should also apply to a PodTemplateSpec (e.g. Deployments, StatefulSets) and provide tests for this
  • Now applies to all core/built-in Kinds with a PodSpecTemplate - Job, Deployment, StatefulSet, DaemonSet

Remaining:

  • Tidy up tests
  • Refactor AdmitFunc tests (moved to new issue)
  • Add handler tests for end-to-end checks
  • Add tests for other Kinds that wrap a PodSpecTemplate
  • Improve error messages (should delineate between missing key, and invalid val)

@elithrar elithrar added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 23, 2019
@elithrar elithrar self-assigned this Jul 23, 2019
@elithrar elithrar force-pushed the elithrar/pod-annotations-admitfunc branch from 55944ea to 6a1ce48 Compare July 23, 2019 03:43
@elithrar elithrar force-pushed the elithrar/pod-annotations-admitfunc branch from e5068fd to 6fb3031 Compare July 25, 2019 22:09
@elithrar elithrar added this to the v1 🚧 milestone Jul 30, 2019
@elithrar elithrar force-pushed the elithrar/pod-annotations-admitfunc branch from a45d9d1 to 8a56429 Compare July 30, 2019 04:27
@elithrar elithrar force-pushed the elithrar/pod-annotations-admitfunc branch from 27ad59f to bf1ff7a Compare August 1, 2019 01:59
@elithrar elithrar force-pushed the elithrar/pod-annotations-admitfunc branch from bf1ff7a to 6538dac Compare August 1, 2019 02:05
@elithrar elithrar force-pushed the elithrar/pod-annotations-admitfunc branch from a25e036 to 095642a Compare August 3, 2019 16:10
@elithrar elithrar merged commit 2da0e28 into master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elithrar elithrar

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v1 🚧
Development

Successfully merging this pull request may close these issues.

[feature] Provide an EnforceXXXAnnotations AdmitFunc
1 participant
@elithrar