Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build due compile time error #5

Closed
lukasmalkmus opened this issue Jun 5, 2018 · 4 comments
Closed

Can't build due compile time error #5

lukasmalkmus opened this issue Jun 5, 2018 · 4 comments

Comments

@lukasmalkmus
Copy link

I tried to vendor the ansimage package using dep. But when compiling my project I see two errors of kind multiple-value colorful.MakeColor() in single-value context in those lines:

_, _, v := colorful.MakeColor(pixel).Hsv()
color := colorful.MakeColor(pixel)

The error makes perfect sense, but I don't get what went wrong here. You may have used a very old version of go-colorful. Check out the releases, I might make sense to update your glide config tot use the 1.0 release.

@eliukblau
Copy link
Owner

eliukblau commented Jun 26, 2018

@lukasmalkmus Yeah. Probably old versions of packages. Thank for observe this. For the moment, I'm evaluating replace Glide with vgo, which will become the default dependency manager for Go.

I will leave this issue open until I change the dependency manager.

@eliukblau eliukblau self-assigned this Jun 26, 2018
@lmorg
Copy link
Contributor

lmorg commented Jan 21, 2019

Regardless of package dependency, this is a pretty simple fix. I've included a PR: #9

Thanks for the good work on this, by the way. I use this package heavily in one of my own projects.

@eliukblau
Copy link
Owner

PR #9 merged :) But this will be released in the upcoming version ;)

@eliukblau eliukblau removed their assignment Jan 24, 2019
@eliukblau
Copy link
Owner

Solved in v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants