Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA] Settings Graphical UI #81

Closed
Tracked by #89
eliweitzman opened this issue May 20, 2024 · 10 comments
Closed
Tracked by #89

[IDEA] Settings Graphical UI #81

eliweitzman opened this issue May 20, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@eliweitzman
Copy link
Owner

Describe the solution you'd like
Create a graphical interface for the ETT Settings config file

@eliweitzman eliweitzman added the enhancement New feature or request label May 20, 2024
@eliweitzman eliweitzman self-assigned this May 20, 2024
eliweitzman added a commit that referenced this issue May 25, 2024
eliweitzman added a commit that referenced this issue May 26, 2024
#81 first try deployed - validation needed in next steps.
@eliweitzman
Copy link
Owner Author

First pass completed and deployed! Moving to testing-needed.

@eliweitzman eliweitzman added the testing-needed An issue that is at the stage of needing testing in a real environment. label May 26, 2024
@eliweitzman
Copy link
Owner Author

Also- adding to 1.3 release

@eliweitzman eliweitzman added this to the ETT 1.3 milestone May 26, 2024
@eliweitzman
Copy link
Owner Author

eliweitzman commented May 26, 2024

Validation Testing Needed:

  • IS the config file the same before and after a setting is updated?
  • Does the modified ps2exe compiler just pull the newly-added Settings ps1 script? @TheDeadGPU

@TheDeadGPU
Copy link
Collaborator

I would say that if a setting is changed, we prompt the user to restart ETT to load in the new settings. I don't see technicians constantly changing settings to the point that we would need to load them back in in real time.Thats just my two cents tho.

@eliweitzman
Copy link
Owner Author

I would say that if a setting is changed, we prompt the user to restart ETT to load in the new settings. I don't see technicians constantly changing settings to the point that we would need to load them back in in real time.Thats just my two cents tho.

For sure! This is currently the implemented flow - and is probably the best way to go anyway given the current PS limitations (we can't do a hot reload easily with the way ETT currently functions as an EXE or PS1).

eliweitzman added a commit that referenced this issue May 27, 2024
Added settings GUI toggle in config file - part of ongoing work in #81
eliweitzman added a commit that referenced this issue May 27, 2024
- Finalization and tweaks for #81 and #76

- Fixed a missing config error suppression bug
@eliweitzman
Copy link
Owner Author

Fixed a few bugs, and we now have a fully-functional settings picker. In addition, there is a new JSON-only control, which enables and disables the user's ability to open the Settings GUI editor (in the off-chance you might want to lock the config due to it living in a shared-use scenario).

@eliweitzman eliweitzman removed the testing-needed An issue that is at the stage of needing testing in a real environment. label May 27, 2024
@eliweitzman
Copy link
Owner Author

This is probably good to go now - leaving this open for review prior to launch

@eliweitzman
Copy link
Owner Author

Found a bug - some values are returned to the JSON config in quotes, when originally not. Working on resolving now.

eliweitzman added a commit that referenced this issue May 27, 2024
@eliweitzman
Copy link
Owner Author

Some embedded casting was added, and we should be clear now.

@eliweitzman
Copy link
Owner Author

closing this out

@eliweitzman eliweitzman mentioned this issue Jun 1, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants