Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Repo.slug/1 helper function #24

Merged
merged 2 commits into from
Jun 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/elixir_bench/repos/repo.ex
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,8 @@ defmodule ElixirBench.Repos.Repo do
|> cast(attrs, [:owner, :name])
|> validate_required([:owner, :name])
end

def slug(repo) do
"#{repo.owner}/#{repo.name}"
end
end
3 changes: 1 addition & 2 deletions lib/elixir_bench_web/schema/content_types.ex
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ defmodule ElixirBenchWeb.Schema.ContentTypes do
field :owner, :string
field :name, :string

field :slug, :string,
resolve: fn repo, _args, _info -> {:ok, "#{repo.owner}/#{repo.name}"} end
field :slug, :string, resolve: fn repo, _args, _info -> {:ok, Repos.Repo.slug(repo)} end

field :benchmarks, list_of(:benchmark) do
resolve(fn %{id: id}, _, _ ->
Expand Down
3 changes: 2 additions & 1 deletion lib/elixir_bench_web/views/job_view.ex
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
defmodule ElixirBenchWeb.JobView do
use ElixirBenchWeb, :view
alias ElixirBenchWeb.JobView
alias ElixirBench.Repos

def render("index.json", %{jobs: jobs, repo: repo}) do
%{data: render_many(jobs, JobView, "job.json", repo: repo)}
Expand All @@ -13,7 +14,7 @@ defmodule ElixirBenchWeb.JobView do
def render("job.json", %{job: %{config: config} = job, repo: repo}) do
%{
id: job.uuid,
repo_slug: "#{repo.owner}/#{repo.name}",
repo_slug: Repos.Repo.slug(repo),
branch_name: job.branch_name,
commit_sha: job.commit_sha,
config: %{
Expand Down
12 changes: 9 additions & 3 deletions test/elixir_bench/repos/repos_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ defmodule ElixirBench.ReposTest do
@valid_attrs %{name: "some name", owner: "some owner"}
@update_attrs %{name: "some updated name", owner: "some updated owner"}
@invalid_attrs %{name: nil, owner: nil}
@repo_slug "some owner/some name"

def repo_fixture(attrs \\ %{}) do
{:ok, repo} =
Expand All @@ -25,7 +26,7 @@ defmodule ElixirBench.ReposTest do

test "get_repo!/1 returns the repo with given id" do
repo = repo_fixture()
assert Repos.fetch_repo_by_slug(repo.owner <> "/" <> repo.name) == {:ok, repo}
assert Repos.fetch_repo_by_slug(@repo_slug) == {:ok, repo}
end

test "create_repo/1 with valid data creates a repo" do
Expand All @@ -49,18 +50,23 @@ defmodule ElixirBench.ReposTest do
test "update_repo/2 with invalid data returns error changeset" do
repo = repo_fixture()
assert {:error, %Ecto.Changeset{}} = Repos.update_repo(repo, @invalid_attrs)
assert Repos.fetch_repo_by_slug(repo.owner <> "/" <> repo.name) == {:ok, repo}
assert Repos.fetch_repo_by_slug(@repo_slug) == {:ok, repo}
end

test "delete_repo/1 deletes the repo" do
repo = repo_fixture()
assert {:ok, %Repo{}} = Repos.delete_repo(repo)
assert Repos.fetch_repo_by_slug(repo.owner <> "/" <> repo.name) == {:error, :not_found}
assert Repos.fetch_repo_by_slug(@repo_slug) == {:error, :not_found}
end
end

test "Repo.changeset/2 returns a repo changeset" do
repo = repo_fixture()
assert %Ecto.Changeset{} = Repos.Repo.changeset(repo, %{})
end

test "Repo.slug/1 returns the repo slug" do
repo = repo_fixture()
assert @repo_slug == Repos.Repo.slug(repo)
end
end