Adds deploy docs #15
Merged
Adds deploy docs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
PragTob
reviewed
Aug 8, 2018
| @@ -1,4 +1,4 @@ | |||
| <img src="../web/public/images/logo.png" height="68" /> | |||
| <img src="https://github.com/elixir-bench/elixir-bench.github.io/blob/master/images/logo.png" height="68" /> | |||
README.md
Outdated
| environment variables for communication with the API server. | ||
| This project uses `distillery` for deployments. The relese requires a `RUNNER_API_URL`, | ||
| `RUNNER_API_KEY` and `RUNNER_API_USER` environment variables for communication with | ||
| the API server. Built releases are placed under `_build/prod/rel/runner` |
There was a problem hiding this comment.
I think this just duplicates the information from the table below, which seems much better imo :) (aka I'd remove the mention of the envs here)
There was a problem hiding this comment.
? They're still up there? The place were you just removed them I actually liked :D
There was a problem hiding this comment.
oh sorry! bad reading 😮 I've just put it back! 👍 😄
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
PragTob
reviewed
Aug 9, 2018
README.md
Outdated
|
|
||
| ```bash | ||
| RUNNER_API_URL=api.elixirbench.org/runner-api RUNNER_API_USER=test-runner RUNNER_API_KEY=test _build/prod/rel/runner/bin/runner foreground |
There was a problem hiding this comment.
I actually liked having them here
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
PragTob
approved these changes
Aug 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.