Homepage #5
Merged
Homepage #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragTob
reviewed
Jul 27, 2018
package.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "name": "web", | |||
| "version": "0.1.0", | |||
| "private": true, | |||
| "homepage": "https://www.elixirbench.org", | |||
| "homepage": "https://elixir-bench.gigalixirapp.com", | |||
There was a problem hiding this comment.
? Shouldn't this stay as is because that's where we'll have it deployed and that's where it should go?
public/CNAME
Outdated
| @@ -1 +0,0 @@ | |||
| www.elixirbench.org | |||
There was a problem hiding this comment.
we need this to keep the URL/DNS record intact
|
|
||
| const IndexPage = ({ classes }) => ( | ||
| <Page> | ||
|
|
There was a problem hiding this comment.
weird blank line nothing big though :D
| <Typography align='justify' className={ classes.gridDescription }> | ||
| ElixirBench is a platform for running benchmarks for projects hosted | ||
| on Github.Etiam hendrerit mattis sapien, eu placerat eros posuere | ||
| vitae. Duis accumsan porta nunc et scelerisque. Lorem ipsum dolor sit amet. |
There was a problem hiding this comment.
might wanna get rid off the lorem ipsum :)
| Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer venenatis | ||
| diam id quam lobortis consequat. Lorem ipsum dolor sit amet, consectetur | ||
| adipiscing elit. Etiam hendrerit mattis sapien, eu placerat eros posuere | ||
| vitae. Duis accumsan porta nunc et scelerisque. |
| oisuer Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer venenatis | ||
| diam id quam lobortis consequat. Lorem ipsum dolor sit amet, consectetur | ||
| adipiscing elit. Etiam hendrerit mattis sapien, eu placerat eros posuere | ||
| vitae. |
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
PragTob
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.