Resolve subdivision aliases #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR closes #33, by resolving subdivision aliases.
Schultzer
force-pushed
the
resolve-subdivision-aliases
branch
4 times, most recently
from
eafdb6b
to
2de24bd
Compare
Schultzer
force-pushed
the
resolve-subdivision-aliases
branch
from
2de24bd
to
3af8bf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #33 by resolving subdivision aliases.
Some subdivision aliases to a territory e.g. Puerto Rico, which can have different styles for their translation,
currently only the standard style is returned in those cases.