Updates for ex_cldr 2.38.0 + bug fix #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make currency info sorted to be deterministic Fix currency tests (CUP no longer exists, use :HT example)
Schultzer
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
ex_cldr_territoriesversion 2.8.1 from hex, compilation fails withex_cldrversion 2.38.0 released yesterday. Howeverex_cldr_territoriesfrom master works perfectly fine so hopefully you're able to publish an update soon?In running the tests with
ex_cldrversion 2.38.0 there are some data changes which made some tests fail due to either a difference in data sort order or because 2 doctests expected Cuba to have two currencies (the CUP has now been discontinued - so I changed the tests to use Haiti which still has two currencies).Summary of changes