Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade pymongo to 4.7.2 #220

Merged
merged 8 commits into from
May 20, 2024
Merged

build: upgrade pymongo to 4.7.2 #220

merged 8 commits into from
May 20, 2024

Conversation

uniqueg
Copy link
Member

@uniqueg uniqueg commented May 19, 2024

Description

  • Upgrade pymongo from 3.10.1 to 4.7.2
  • Upgrade MongoDB in petstore app Docker Compose configs from 3.6 to 7.0
  • Replace pymongo.cursor.count() with pymongo.collection.count_documents() (see note)
  • Fix various type checking issues

Fixes #212

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • N/A I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (or documentation does not need to be updated)
  • My changes generate no new warnings
  • N/A I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage

@uniqueg uniqueg changed the base branch from upgrade_pymongo to dev May 19, 2024 22:36
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (19c127b) to head (5a6883b).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #220   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          975       974    -1     
=========================================
- Hits           975       974    -1     
Flag Coverage Δ
test_unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uniqueg uniqueg marked this pull request as ready for review May 20, 2024 00:24
@uniqueg uniqueg changed the title temporarily downgrade to latest pymongo 3 version build: upgrade pymongo to 4.7.2 May 20, 2024
@uniqueg uniqueg requested a review from athith-g May 20, 2024 00:25
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @uniqueg - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 7 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@uniqueg uniqueg mentioned this pull request May 20, 2024
7 tasks
@uniqueg uniqueg merged commit 63456a5 into dev May 20, 2024
19 checks passed
@uniqueg uniqueg deleted the fix_pymongo_upgrade branch May 20, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: upgrade pymongo to 4.7.2
1 participant