feat: add support for path parameters #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #44 +/- ##
=======================================
Coverage 99.70% 99.71%
=======================================
Files 11 11
Lines 689 699 +10
=======================================
+ Hits 687 697 +10
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
uniqueg
reviewed
Apr 9, 2023
|
No new tests have been added. The old tests which had the path parameters in them were modified with this new feature. I removed the TES code and made path parameters part generic as well. |
|
Okay, then. Probably shouldn't have looked at it after my third beer 😅 |
uniqueg
approved these changes
Apr 10, 2023
uniqueg
changed the title
lbeckman314
pushed a commit
to lbeckman314/tes-compliance-suite
that referenced
this pull request
Apr 22, 2023
lbeckman314
added a commit
to lbeckman314/tes-compliance-suite
that referenced
this pull request
Apr 28, 2023
Co-authored-by: Liam Beckman <lbeckman314@gmail.com> feat: add filter functionality and tests (elixir-cloud-aai#33) feat: add test file description in report (elixir-cloud-aai#41) feat: add path parameters (elixir-cloud-aai#44) feat: add test for ignore_error flag (TES v1.1.0) (elixir-cloud-aai#45) feat: add tests for pagination options (elixir-cloud-aai#47) feat: support query parameter transformation (elixir-cloud-aai#46) Exit test suite with error code if any tests fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42