Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the static documentation to ex_doc #32

Merged
merged 3 commits into from
Dec 10, 2019

Conversation

oltarasenko
Copy link
Collaborator

No description provided.

@Ziinc
Copy link
Collaborator

Ziinc commented Dec 10, 2019

Will we be using https://oltarasenko.github.io/crawly/ or the one on hexdocs https://hexdocs.pm/crawly/api-reference.html ? if we're using the hexdocs endpoint, then i'll remove files for the github pages

@Ziinc
Copy link
Collaborator

Ziinc commented Dec 10, 2019

the site at hexdocs has a higher google ranking

@oltarasenko
Copy link
Collaborator Author

I would move to hexdocs eventually. The problem here is that current github pages has several links from articles I have written before. So I would want to keep it for some time (or to make a link from github pages to hexdocs (I kind of like what I see on hexdocs already))

@Ziinc
Copy link
Collaborator

Ziinc commented Dec 10, 2019

Looks good to me, I've made more edits and merged some sections of the guide. I've also grouped the modules together based on reader relevance.

I think the docs can be made more concise, but I'll do that on a separate PR.

@Ziinc
Copy link
Collaborator

Ziinc commented Dec 10, 2019

travis checks failed for a non-related test. Good to merge

@oltarasenko
Copy link
Collaborator Author

I think one of the tests has a race condition. I will merge this now.

@oltarasenko oltarasenko merged commit e513d49 into master Dec 10, 2019
@oltarasenko oltarasenko deleted the documentation_improvements branch December 10, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants