Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browser rendering support #59

Merged
merged 1 commit into from Feb 19, 2020
Merged

Add browser rendering support #59

merged 1 commit into from Feb 19, 2020

Conversation

oltarasenko
Copy link
Collaborator

Added a fetcher with uses a Splash browser renderer in order to fetch
pages with it.

Ziinc
Ziinc previously approved these changes Feb 19, 2020
View reviewed changes
Copy link
Collaborator

@Ziinc Ziinc left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue in the url building not being very clean. Looks good.

~~Though the HTTPoison response will contain the request that has the config options for slash. Don't think that is desirable ~~

Ah OK I see why you did the url replacement there. 👍

lib/crawly/fetchers/splash.ex Outdated Show resolved Hide resolved
@oltarasenko
Add browser rendering support
6eab6f1 
Added a fetcher with uses a Splash browser renderer in order to fetch
pages with it.
@oltarasenko oltarasenko merged commit 02515a2 into master Feb 19, 2020
@oltarasenko oltarasenko deleted the splash_fetcher_impl branch February 19, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ziinc Ziinc Ziinc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oltarasenko @Ziinc