New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing endpoint.ex to "use Desktop.Endpoint" breaks Desktop app #39
Comments
So, after delving into the source code, I am of the opinion the documentation (https://github.com/elixir-desktop/desktop/blob/main/guides/your_first_app.md) needs to be updated, specifically:
Needs to be:
As v1.4 breaks with Phoenix LiveView 1.18. More info: https://elixirforum.com/t/changing-endpoint-ex-to-use-desktop-endpoint-breaks-desktop-app/56550/3 |
Fl4m3Ph03n1x
added a commit
to Fl4m3Ph03n1x/desktop
that referenced
this issue
Jun 16, 2023
dominicletz
pushed a commit
that referenced
this issue
Jun 20, 2023
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
I have created a fresh Phoenix app using
mix phx.new.web web_interface --no-dashboard --no-ecto --no-gettext --no-mailer
inside an Umbrella app.After following the basic installation instructions for the dependencies and changing my
application.ex
to:I was able to launch my Desktop application and have it working.
Problem
However, after changing
endpoint.ex
following the instruction #3 here:I was no longer able to launch the application due to an error:
To me, this indicates that changing
Phoenix.Endpoint
toDesktop.Endpoint
is no longer necessary.Question
It is worth noting however, that the creation of Phoenix projects inside Umbrella applications is currently bugged (see: https://elixirforum.com/t/phoenix-1-7-welcome-page-assets-not-showing-properly/55969) but I don't think this is related.
The text was updated successfully, but these errors were encountered: