Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_field for nested changesets should filter out deleted entries for has_many relations #875

Closed
sumerman opened this issue Aug 13, 2015 · 5 comments
Closed

get_field for nested changesets should filter out deleted entries for has_many relations #875

sumerman opened this issue Aug 13, 2015 · 5 comments

Comments

@sumerman
Copy link
Contributor

When I use Changeset.get_change I expect it to return what it returns now, but for the Changeset.get_field the expectation is to return the value as if it comes from the model.
@josevalim
Copy link
Member

Agreed. @michalmuskala can you please take a look?

@michalmuskala
Copy link
Member

Yes, I'll look into this.

@michalmuskala
Copy link
Member

Should it return changesets or models? I believe it should be applied models

@sumerman
Copy link
Contributor Author

@michalmuskala models would be the least surprising thing

michalmuskala added a commit to michalmuskala/ecto that referenced this issue Aug 13, 2015
@michalmuskala
get_field/3 and fetch_field/2 for relations return models
527f137 
Closes elixir-ecto#875
@michalmuskala michalmuskala mentioned this issue Aug 13, 2015
Merged
@sumerman
Copy link
Contributor Author

@michalmuskala thanks

@sumerman sumerman mentioned this issue Aug 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@josevalim @sumerman @michalmuskala