Support selecting into structs #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ebert has finished reviewing this Pull Request and has found:
But beware that this branch is 12 commits behind the You can see more details about this review at https://ebertapp.io/github/elixir-ecto/ecto/pulls/1947. |
josevalim
reviewed
Feb 13, 2017
integration_test/cases/repo.exs
Outdated
| @@ -892,6 +892,8 @@ defmodule Ecto.Integration.RepoTest do | |||
|
|
|||
| ## Query syntax | |||
|
|
|||
| defstruct [:title] | |||
There was a problem hiding this comment.
Let's please define a module because this is a bit "lost" in the middle of the file.
|
Just one tiny comment and this is good to go! |
michalmuskala
force-pushed
the
mm/select-struct
branch
from
7c888d5
to
b25e7be
Compare
|
@josevalim updated |
|
❤️ 💚 💙 💛 💜 |
bartekupartek
pushed a commit
to bartekupartek/ecto
that referenced
this pull request
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables queries like
from(c in City, select: %Data{name: c.name})to work, which might be especially interesting in case of complex joins or schemaless queries.