Ecto benchmarks #2607
Ecto benchmarks #2607
Conversation
- Adds initial setup - Adds ElixirBench config.yml - Adds benchmarks for Repo.insert!/1
- Adds benchmarks for Repo.all/1, Repo.load/2 and Repo.to_sql/2 Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
- Adds bigger queries to to_sql_bench - Adds more attribute types, such as datetimes, naivedate, time to load_bench Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
tallysmartins
force-pushed
the
ecto_bench
branch
from
41c3b23
to
4888595
Compare
bench/README.md
Outdated
| To run the benchmarks tests just type in the console: | ||
|
|
||
| ``` | ||
| $ export BENCHMARKS_OUTPUT_PATH=bench/results && mix run bench/bench_helper.exs |
There was a problem hiding this comment.
Use BENCHMARKS_OUTPUT_PATH=bench/results mix run bench/bench_helper.exs in POSIX-compatible shells and env BENCHMARKS_OUTPUT_PATH=bench/results mix run bench/bench_helper.exs in rest of them.
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
bench/README.md
Outdated
|
|
||
| ``` | ||
| # other shells | ||
| $ env BENCHMARKS_OUTPUT_PATH=bench/results && mix run bench/bench_helper.exs |
There was a problem hiding this comment.
In both cases without the && part.
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
|
Here are some of the results that I've gotten from running in my laptop. |
|
Any way we can help move this PR along @hauleth ? 😁 |
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
|
|
||
| # Clean inserted data | ||
| Ecto.Bench.PgRepo.delete_all(User) | ||
| Ecto.Bench.MySQLRepo.delete_all(User) |
There was a problem hiding this comment.
Could we move the cleanup code to the beginning of the benchmark instead of the end? That way if something goes wrong during the benchmark the next run should be fine.
There was a problem hiding this comment.
Edited: I don't think we need to do a pre cleanup because in the setup we call storage_down and this already clean the db.. doesn't it?
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
| "MySQL Repo.all/2" => fn -> Ecto.Bench.MySQLRepo.all(User, limit: limit) end | ||
| } | ||
|
|
||
| path = System.get_env("BENCHMARKS_OUTPUT_PATH") || raise "I DON'T KNOW WHERE TO WRITE!!!" |
There was a problem hiding this comment.
What do you think about using bench/results as default value?
And maybe move it to Application env?
Application.put_env(
:ecto,
:bench_results_path,
System.get_env("BENCHMARKS_OUTPUT_PATH") || "bench/results"
)
There was a problem hiding this comment.
Well, it is concerned to ElixirBench to set this variable in order to collect and clean the results, so raising here means that something went wrong in our runners. In the near future we want to wrap this kind of settings, so I don't think it will make big difference moving this now.
bench/README.md
Outdated
| $ env BENCHMARKS_OUTPUT_PATH=bench/results MIX_ENV=bench mix run bench/bench_helper.exs | ||
| ``` | ||
|
|
||
| Benchmarks are inside the benchmarks/ directory and are divided into two |
There was a problem hiding this comment.
Minor nitpicks:
- I wouldn't use backticks for Potgres and MySQL:
and need PostgreSQL and MySQL up and running.
Also, I would use "PostgreSQL" instead of "Postgres
- I would use backticks for the dir:
Benchmarks are inside the `benchmarks/` directory
- And maybe use bullet points for the list of categories?
* `micro benchmarks`: Operations that don't actually interface with the database,
but might need it up and running to start the Ecto agents and processes.
* `macro benchmarks`: Operations that are actually run in the database. This are
more likely to integration tests.
There was a problem hiding this comment.
Thanks for your considerations! ❤️
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
|
❤️ 💚 💙 💛 💜 |
The initial benchmark suite for Ecto. Tests rely on the Benchee library.