Automatically set first order_by when distinct set #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -213,12 +213,16 @@ if Code.ensure_loaded?(Postgrex.Connection) do | |||
| end | |||
| end | |||
|
|
|||
| defp order_by(order_bys, sources) do | |||
| defp order_by([], _distincts, _sources), do: nil | |||
There was a problem hiding this comment.
If order_by is empty, we should still generate the order by for distincts.
|
It would be more efficient to build the SQL for distinct once and reuse that in order_by. Would that be possible? |
|
@ericmj yeah. |
gjaldon
force-pushed
the
automatically-set-order-by
branch
2 times, most recently
from
25f0282
to
68e8ef6
Compare
gjaldon
changed the title
|
@josevalim @ericmj are the latest changes okay? |
| "" -> nil | ||
| _ -> "ORDER BY " <> exprs | ||
| case {distinct_exprs, exprs, distinct} do | ||
| {_, "", _} -> nil |
There was a problem hiding this comment.
We should add the distinct_exprs to order by even if there is no order_by, no?
josevalim
added a commit
that referenced
this pull request
Mar 8, 2015
Automatically set first order_by when distinct set
|
❤️ 💚 💙 💛 💜 |
|
Thanks, guys! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this issue: #495
My initial implementation for this enhancement but will need to add docs and test it some more.