Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repro-repo suggestion to issue template #38

Merged
merged 3 commits into from Nov 24, 2018
Merged

Conversation

michalmuskala
Copy link
Member

No description provided.

@@ -17,5 +17,8 @@

Include code samples, errors and stacktraces if appropriate.

If you can, please provide an example repository that reproduces the error, that maintainers could clone and check locally. This will speed-up the process tremendously - it's very likely you'll be asked to provide one anyway.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be "that maintainers can clone and check locally"

### Expected behavior

Describe expected behaviour
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Behavior" to match the headings?

Copy link
Member

@qcam qcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@josevalim josevalim merged commit 86b2cc4 into master Nov 24, 2018
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

@josevalim josevalim deleted the michalmuskala-patch-1 branch November 24, 2018 21:13
zachdaniel pushed a commit to zachdaniel/ecto_sql that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants