New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fallback generic with no query parameters #605

Merged

greg-rychlewski merged 2 commits into elixir-ecto:master from greg-rychlewski:generic_explain_fix

May 4, 2024

Member

greg-rychlewski commented May 4, 2024 •

edited

Loading

I had a bug in the old code when no query parameters are present. 1..num_params returns a list of 2 values instead of empty list.

Also postgres doesn't like empty parentheses for these functions.


          fix fallback generic with no query parameters

d2c1f1b

josevalim approved these changes

View reviewed changes


          better name

f882fcc

greg-rychlewski merged commit 52e49a2 into elixir-ecto:master

10 checks passed

greg-rychlewski deleted the generic_explain_fix branch

May 4, 2024 16:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment