Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update human clinical and health data sources page #93

Merged
merged 24 commits into from Jan 23, 2024

Conversation

IrisVanDam
Copy link
Contributor

As we were encouraged to get familiar with GitHub I'm trying to add a first few lines of text to the human clinical and health data sources page. This is a first draft to try everything out, but hopefully it's a start.

As we were encouraged to get familiar with GitHub I'm trying to add a first few lines of text to the human clinical and health data sources page. This is a first draft to try everything out, but hopefully it's a start.
@IrisVanDam IrisVanDam requested a review from a team as a code owner October 25, 2022 14:14
As we were encouraged to get familiar with GitHub I'm trying to add a first few lines of text and an image to the human clinical and health data sources page.
@bedroesb bedroesb self-requested a review as a code owner October 26, 2022 15:07
@rabuono
Copy link
Collaborator

rabuono commented Oct 28, 2022

Great start!
Might be best to move the PR to draft until the page has enough content to be published.

@rabuono rabuono marked this pull request as draft October 28, 2022 13:10
@stain
Copy link
Member

stain commented Dec 5, 2022

This is great, @IrisVanDam. Which other sections do we need below this intro?

I fixed a Git conflict that occured as there were edits on the same file.

Could you modify the pull request to use more web-like citations/hyperlinks? For instance, rather than

references 1;

Try:

references EMA's guidance for publication of clinical data (etc)

BTW, for citing Zenodo I would use the DOI, e.g. https://doi.org/10.5281/zenodo.6787119

@lauportell
Copy link
Contributor

Closes #109

Aligned page with latest text Google Drive
@IrisVanDam IrisVanDam marked this pull request as ready for review June 26, 2023 13:43
@bedroesb bedroesb linked an issue Jun 26, 2023 that may be closed by this pull request
Copy link
Contributor

@ShonaCosgrove ShonaCosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think the page has a lot of good and useful information! I just found the structure a bit confusing and felt that it jumps back and forth between topics a bit.

Maybe you could change the structure to:

  1. Introduction
  2. Organisation of health data: including commonalities and differences between countries
  3. Finding (meta)data: including metadata catalogeues, RIs etc
  4. Accessing data: including the information you have under access now, and move the regulatory aspects here

Essentially just adding a section 'Organisation' and moving some of the information from findability to access. I made some other small suggestions to wording. Happy to look at it together as well :)

human_clinical_and_health_data/data_sources.md Outdated Show resolved Hide resolved
human_clinical_and_health_data/data_sources.md Outdated Show resolved Hide resolved
human_clinical_and_health_data/data_sources.md Outdated Show resolved Hide resolved
human_clinical_and_health_data/data_sources.md Outdated Show resolved Hide resolved
human_clinical_and_health_data/data_sources.md Outdated Show resolved Hide resolved
human_clinical_and_health_data/data_sources.md Outdated Show resolved Hide resolved
human_clinical_and_health_data/data_sources.md Outdated Show resolved Hide resolved
human_clinical_and_health_data/data_sources.md Outdated Show resolved Hide resolved
human_clinical_and_health_data/data_sources.md Outdated Show resolved Hide resolved
human_clinical_and_health_data/data_sources.md Outdated Show resolved Hide resolved
The changes suggested by Shona have been made and the page reorganised. Currently I'm not yet happy with the section 'Finding (meta)data - Considerations'. Any suggestions?
IrisVanDam and others added 5 commits December 5, 2023 13:43
This update addresses the latest feedback received from Shona and Laura. If all is well the page should be near ready to be published.
@bedroesb
Copy link
Member

@elixir-europe/idtk-editors This PR is ready for review! Can an editor volunteer for this page to review it?

@lauportell
Copy link
Contributor

New page for clinical and health data sources

@lauportell lauportell merged commit d2422f4 into main Jan 23, 2024
6 checks passed
@lauportell lauportell deleted the IrisVanDam-patch-1-1 branch January 23, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data sources - Human clinical and health data
6 participants