Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cz_resources.md #1029

Merged
merged 9 commits into from Nov 9, 2022
Merged

Create cz_resources.md #1029

merged 9 commits into from Nov 9, 2022

Conversation

KarelBerka
Copy link
Contributor

First draft on the Czech Republic RDM resources

First draft on the Czech Republic RDM resources
Copy link
Collaborator

@Nazeeefa Nazeeefa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating and sharing this page. I hope you find the review helpful.

pages/national_resources/cz_resources.md Show resolved Hide resolved
pages/national_resources/cz_resources.md Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
Co-authored-by: Nazeeefa <fatima.nazeefa@gmail.com>
pages/national_resources/cz_resources.md Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
pages/national_resources/cz_resources.md Outdated Show resolved Hide resolved
@KarelBerka KarelBerka requested review from Nazeeefa and removed request for lauportell October 31, 2022 14:48
Copy link
Collaborator

@Nazeeefa Nazeeefa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some changes to be made but the changes applied here can be approved :)

instance_of: Galaxy
related_pages:
tool_assembly: [ ]
your_domain: [plant_sciences]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, make sure that the page ids are the ones listed here https://rdmkit.elixir-europe.org/website_overview (without underscores)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I forgot the IDs are not same as page URLs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it is one of the sustainability topics I would love to talk about on our Hackathon :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I help here with something? I am a bit puzzled what I should do next to help the page be up and running...

Copy link
Member

@bedroesb bedroesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also before merging we have to look into the build error, I can have a look tomorrow!

@bedroesb
Copy link
Member

bedroesb commented Nov 3, 2022

Ok I fixed some indentation problems, if we fix the page ids we are good to go!

@bedroesb bedroesb linked an issue Nov 3, 2022 that may be closed by this pull request
Copy link
Contributor Author

@KarelBerka KarelBerka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only IDs are needed, I have probably nothing more to add at the moment.

@bedroesb bedroesb merged commit 5afaf64 into elixir-europe:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Czech Republic RDM national resources page
3 participants