Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Exploring Explorer" notebook for Livebook v0.4 #100

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

philss
Copy link
Member

@philss philss commented Jan 18, 2022

This change removes the warning about deprecated way of reading
filenames. The new form now is by using Kino.Input.

This change also removes some markdown code blocks for options
descriptions. The idea is to read them as markdown, which is more
pleasant.

This change removes the warning about deprecated way of reading
filenames. The new form now is by using Kino.Input.

This change also removes some markdown code blocks for options
descriptions. The idea is to read them as markdown, which is more
pleasant.
@@ -4,19 +4,17 @@

Connect to a `Mix` project with `Explorer` installed or:

<!-- livebook:{"force_markdown":true} -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't understand the intention here. I removed in order to run the Elixir cell. Is that OK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely okay. I'm not sure why I had set it to markdown in the first place.

Copy link
Member

@cigrainger cigrainger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! <3

@@ -4,19 +4,17 @@

Connect to a `Mix` project with `Explorer` installed or:

<!-- livebook:{"force_markdown":true} -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely okay. I'm not sure why I had set it to markdown in the first place.

@cigrainger cigrainger merged commit 757d249 into elixir-explorer:main Jan 18, 2022
@philss philss deleted the ps-update-notebook branch January 18, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants