Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump polars #130

Merged
merged 3 commits into from
Mar 16, 2022
Merged

bump polars #130

merged 3 commits into from
Mar 16, 2022

Conversation

cigrainger
Copy link
Member

@cigrainger cigrainger commented Mar 16, 2022

Bumps polars to 0.20.0 and fixes some uncaught bugs in the process 馃槵!

  • Polars was treating literal nulls as empty strings when reading CSV strings
  • Rolling min/mean seemed to be adding a 0 value before the first actual value
  • I'm not sure what was going on with the dtypes assertion on read_csv but there's no way the Rust-side code for generating the schema was right
  • Fixes inconsistency when running Explorer.DataFrame.pivot_wider/4聽#115! Appears there's some more stability now.

Delving into lazy eval now so I don't plan on bumping polars again until that's done :).

This switches from shell.nix to flake.nix. I understand the desire to avoid including dev environment info in the repo, but Nix flakes actually act in a packaging capacity as well and I intend to make Explorer available as a flake for others. Flakes also must be checked in to version control.


## Examples

iex> df = Explorer.DataFrame.from_map(%{id: [1, 1], variable: ["a", "b"], value: [1, 2]})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat unrelated: another reason to call this function from_series is that we could receive any enumerable as a series. This could be beneficial because keywords preserve key ordering but maps do not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point. No reason not to take a keyword list here. I'll raise an issue and make the change.

@cigrainger cigrainger merged commit dee679b into main Mar 16, 2022
@cigrainger cigrainger deleted the chris/bump-polars branch March 16, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistency when running Explorer.DataFrame.pivot_wider/4
2 participants