use strings (not atoms) for column names in dtype specification #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 21, 2021
| @@ -54,7 +54,7 @@ defmodule Explorer.DataFrame do | |||
| ## Options | |||
|
|
|||
| * `delimiter` - A single character used to separate fields within a record. (default: `","`) | |||
| * `dtypes` - A keyword list of `[column_name: dtype]`. If `nil`, dtypes are imputed from the first 1000 rows. (default: `nil`) | |||
| * `dtypes` - A list of `{"column_name", dtype}` tuples. Uses column names as read, not as defined in options. If `nil`, dtypes are imputed from the first 1000 rows. (default: `nil`) | |||
There was a problem hiding this comment.
Just to throw out there, cause I am not sure it is a good idea, you could also make this be: dtypes: [string: "foo", string: "bar", integer: "baz"].
There was a problem hiding this comment.
I personally like the 2-tuples better
josevalim
reviewed
Sep 21, 2021
| @@ -33,7 +33,7 @@ defmodule Explorer.PolarsBackend.DataFrame do | |||
| dtypes = | |||
| if dtypes do | |||
| Enum.map(dtypes, fn {colname, dtype} -> | |||
| {Atom.to_string(colname), Shared.internal_from_dtype(dtype)} | |||
| {colname, Shared.internal_from_dtype(dtype)} | |||
There was a problem hiding this comment.
It is probably worth adding some validation here (check the types and raise invalid dtype otherwise).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #58