Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DF.arrange options #755

Merged
merged 2 commits into from Dec 5, 2023
Merged

DF.arrange options #755

merged 2 commits into from Dec 5, 2023

Conversation

billylanchantin
Copy link
Contributor

Adds the following options to DF.arrange and DF.arrange_with:

  • nils: :first | :last
  • stable: boolean()

This is a prerequisite for #730 (comment).

billylanchantin
billylanchantin commented Dec 2, 2023
View reviewed changes
Copy link
Contributor Author

@billylanchantin billylanchantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few callouts. Also noteworthy is that I wasn't sure how to test stable vs. non-stable sorting.

native/explorer/src/dataframe.rs Outdated Show resolved Hide resolved
lib/explorer/data_frame.ex Show resolved Hide resolved
@billylanchantin @josevalim
add todo about multithreaded
65f8432 
Co-authored-by: José Valim <jose.valim@dashbit.co>
@billylanchantin billylanchantin merged commit f0062ea into main Dec 5, 2023
4 checks passed
@billylanchantin billylanchantin deleted the bl-add-arrange-options branch December 5, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@billylanchantin @josevalim