Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast string to datetime #795

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Cast string to datetime #795

merged 6 commits into from
Jan 3, 2024

Conversation

billylanchantin
Copy link
Contributor

Fixes a bug (regression?) where casting from string to datetime always resulted in nil.

Closes:

Copy link
Member

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion. Overall it looks good!

lib/explorer/polars_backend/series.ex Outdated Show resolved Hide resolved
native/explorer/src/series.rs Outdated Show resolved Hide resolved
lib/explorer/polars_backend/series.ex Outdated Show resolved Hide resolved
Copy link
Member

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@billylanchantin billylanchantin merged commit d53429f into main Jan 3, 2024
4 checks passed
@billylanchantin billylanchantin deleted the bl-cast-string-to-datetime branch January 3, 2024 15:49
@billylanchantin billylanchantin mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants