Implements Series.split_into/3 #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Mar 3, 2024
josevalim
reviewed
Mar 3, 2024
|
This is looking great so far @ryancurtin! The last step is to implement the feature for the lazy backend as well and add a test. The lazy backend is the one used inside DF.mutate and friends. You can see other PRs, such as this one, for examples: #859 |
Co-authored-by: José Valim <jose.valim@gmail.com>
|
@josevalim - Ok, I've re-requested review since I've now implemented the lazy backend and added some tests using a DataFrame. Thank you again for your help! |
lkarthee
reviewed
Mar 4, 2024
josevalim
reviewed
Mar 4, 2024
|
Three remaining comments and we will ship it :D |
josevalim
reviewed
Mar 4, 2024
… longer use ChunkedArray
|
Thanks again @josevalim and @lkarthee - I've made the suggested changes! |
lkarthee
approved these changes
Mar 4, 2024
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
Series.split_into/3function, which closes #871. String columns can be split into a struct with multiple fields.