Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let {:datetime, _} be an alias for {:naive_datetime, _} for backwards compatibility #924

Merged
merged 8 commits into from
Jun 9, 2024
Merged

Let {:datetime, _} be an alias for {:naive_datetime, _} for backwards compatibility #924

merged 8 commits into from
Jun 9, 2024

Conversation

billylanchantin
Copy link
Contributor

@billylanchantin billylanchantin commented Jun 8, 2024 •
edited
Loading

Description

Allows {:datetime, _} as an alias for {:naive_datetime, _}. This will prevent the next release from being breaking.

Extras

  • Fix a typo the series moduledoc
  • Fix a bug in the query_to_lazy_series! conversion fun

billylanchantin
billylanchantin commented Jun 8, 2024
View reviewed changes
lib/explorer/shared.ex Show resolved Hide resolved
lib/explorer/data_frame.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Jun 9, 2024
View reviewed changes
lib/explorer/series.ex Outdated Show resolved Hide resolved
billylanchantin and others added 2 commits June 9, 2024 09:39
@billylanchantin @josevalim
don't document the deprecated alias
6746f2a 
Co-authored-by: José Valim <jose.valim@dashbit.co>
@billylanchantin
use microsecond
c278300
josevalim
josevalim approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good once CI passes!

@billylanchantin billylanchantin merged commit 1d69e69 into main Jun 9, 2024
4 checks passed
@billylanchantin billylanchantin deleted the bl-dtype-alias-datetime branch June 9, 2024 21:28
@billylanchantin billylanchantin mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@billylanchantin @josevalim