Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct casing in module names (PO and MO) #69

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Use correct casing in module names (PO and MO) #69

merged 1 commit into from
Jul 30, 2022

Conversation

whatyouhide
Copy link
Contributor

In Elixir we use uppercase module names when we have acronyms in the module names, such as PO or MO. See URI for example.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2ec86a6007d98978161bc8e4bcf57c490b255388-PR-69

  • 5 of 5 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1a9083d3d42b6266f9b72f9c05cec55f5ec12a0f: 0.0%
Covered Lines: 368
Relevant Lines: 368
💛 - Coveralls

@maennchen maennchen merged commit d62c546 into main Jul 30, 2022
@maennchen maennchen deleted the andrea/renamae branch July 30, 2022 08:48
@maennchen maennchen mentioned this pull request Jul 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

@maennchen maennchen maennchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@whatyouhide @coveralls @josevalim @maennchen