Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keeping or deleting obsolete translations #210

Closed
whatyouhide opened this issue Aug 13, 2019 · 2 comments
Closed

Keeping or deleting obsolete translations #210

whatyouhide opened this issue Aug 13, 2019 · 2 comments
Assignees
@whatyouhide
Labels
Kind:Feature Level:Starter

Comments

@whatyouhide
Copy link
Contributor

When we are merging an old PO file with a new POT file, we remove all translations in the old PO that don't match anything in the new POT. However, the msgmerge tool actually marks them as obsolete:

#~ msgid "hello"
#~ msgstr "ciao"

Should we do the same, or are we good with removing them?

\cc @josevalim
@josevalim
Copy link
Contributor

@whatyouhide sounds good to me!

@kipcole9 kipcole9 mentioned this issue Sep 8, 2019
Closed
@halostatue
Copy link
Contributor

It would also be good to consider the changed marker if it can be detected:

#| msgid "Old Translation Key"
msgid "New Translation Key"
msgstr ""

@whatyouhide whatyouhide self-assigned this Dec 19, 2021
@whatyouhide whatyouhide mentioned this issue Dec 20, 2021
Merged
maennchen added a commit to jshmrtn/gettext that referenced this issue Jul 20, 2022
@maennchen
Support marking messages as obsolete
bf41e75 
Implements elixir-gettext#210
@maennchen maennchen mentioned this issue Jul 20, 2022
Merged
maennchen added a commit to jshmrtn/gettext that referenced this issue Aug 1, 2022
@maennchen
Support marking messages as obsolete
34f59bc 
Implements elixir-gettext#210
maennchen added a commit to jshmrtn/gettext that referenced this issue Aug 2, 2022
@maennchen
Support marking messages as obsolete
7bb135c 
Implements elixir-gettext#210
maennchen added a commit to jshmrtn/gettext that referenced this issue Aug 2, 2022
@maennchen
Support marking messages as obsolete
b9d8398 
Implements elixir-gettext#210
maennchen added a commit to jshmrtn/gettext that referenced this issue Aug 2, 2022
@maennchen
Support marking messages as obsolete
f77a464 
Implements elixir-gettext#210
maennchen added a commit to jshmrtn/gettext that referenced this issue Aug 2, 2022
@maennchen
Support marking messages as obsolete
4484009 
Implements elixir-gettext#210
maennchen added a commit to jshmrtn/gettext that referenced this issue Aug 2, 2022
@maennchen
Support marking messages as obsolete
5eca694 
Implements elixir-gettext#210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whatyouhide whatyouhide

Labels
Kind:Feature Level:Starter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@josevalim @halostatue @whatyouhide