Duplicate translations #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces checks for duplicate translations when parsing PO files. Duplicate translations will result in a parse error.
This function now uses throw/catch in order to traverse a list of translations only once to find duplicates. The code is very contained and straightforward, so throw/catch shouldn't be a problem here. The upside of doing this is speed and simplicity; the downside, however, is that we only find the first duplicate of a translation (instead of all the duplicates of that translation). For now, this is fine since duplicate translations should be a not very common case.
| :ok | ||
| catch | ||
| {old_line, line} -> | ||
| {:error, line, "found duplicate of this translation on line #{old_line}"} |
There was a problem hiding this comment.
Should we include the msgid in the error message?
There was a problem hiding this comment.
@josevalim We could, of course :) do you think very long msgids could be a problem?
edit maybe we can truncate them with ...?
There was a problem hiding this comment.
@whatyouhide yeah, we could show just the first line and truncate with ... if more than one. Another idea is to do this:
"found duplicate on line #{old_line} for msgid: #{the whole message id}"
If it is at the end, it is not such a big problem to be long.
|
👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles duplicate translations. The implementation of the function that checks for duplicates uses
throw/catchin order to traverse the list of translations only one but the code is very simple and straightforward, so that should not be a problem. Thanks @josevalim for the help!