Fuzzy translations #42
Conversation
| If the translations are not of the same type (e.g., a translation and a plural | ||
| translation), `-1` is returned. | ||
| """ | ||
| @spec jaro_distance(Gettext.PO.translation, Gettext.PO.translation) :: 0..1 | -1 |
There was a problem hiding this comment.
I don't see where -1 would come from.
There was a problem hiding this comment.
Whooops, documented the spec but forgot to implement that. :)
|
@josevalim pushed a couple of new commits and left a bunch of comments around the code. Let me know what you think :) |
|
This looks great. Now we just need how to make the fuzzy configurable as well as the threshold. We can probably do something like this: Where fuzzy match receives two translations and returns The matcher will return an anonymous function as defined above and will return Thoughts? |
|
Got it, will start working on it right now :) |
whatyouhide
force-pushed
the
fuzzy-matching
branch
from
33fc003
to
1ddd6fc
Compare
|
@josevalim implemented |
|
Beautiful. Now let's make use of it in gettext.merge, provide the proper options, and ship it! :D |
This module takes care of * finding how similar two translations are * fuzzy-merging two translations
This function is used to return a matcher that tells if two translations are a fuzzy match.
whatyouhide
force-pushed
the
fuzzy-matching
branch
from
1ddd6fc
to
4998786
Compare
|
@josevalim pushed the |
| alias Gettext.Merger | ||
|
|
||
| def run(args) do | ||
| _ = Mix.Project.get! | ||
|
|
||
| case OptionParser.parse(args, strict: [locale: :string]) do | ||
| parse_switches = [locale: :string, fuzzy: :boolean, fuzzy_threshold: :float] | ||
| case OptionParser.parse(args, strict: parse_switches) do | ||
| {opts, [arg1, arg2], _} -> |
There was a problem hiding this comment.
The third element of the tuple are option parsing errors. Maybe we should check they are not empty and print them somehow.
There was a problem hiding this comment.
Maybe something like this:
{_, _, [_|_] = errors} ->
for {key, _} <- errors, do: Mix.shell.error "#{key} is invalid"
Mix.raise "mix gettext.merge aborted."
| The following options are forwarded to the `gettext.merge` task, which is | ||
| called internally by this task: | ||
|
|
||
| * `--fuzzy` |
There was a problem hiding this comment.
--no-fuzzy. I would actually reword the paragraph to say that it supports the same option as gettext.merge in those cases and just show an example. :)
|
@josevalim pushed the fixes to the docs, I'm merging this PR. I'll polish the docs a little bit and then we can release 0.6.0 🎉 |
Hey @josevalim, can you have a look at this when you have some time? It's just the foundations of how fuzzy matching would work. It's very simple, but not configurable (I guess we should pass things like
--fuzzy/--no-fuzzyand other options togettext.merge).Wdyt?